Repository navigation
chore(deps): bump bn.js from 4.12.5 to 5.2.5 - #405
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [bn.js](https://github.com/indutny/bn.js) from 4.12.5 to 5.2.5. - [Release notes](https://github.com/indutny/bn.js/releases) - [Changelog](https://github.com/indutny/bn.js/blob/master/CHANGELOG.md) - [Commits](indutny/bn.js@v4.12.5...v5.2.5) --- updated-dependencies: - dependency-name: bn.js dependency-version: 5.2.5 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
4aab81c to
828c4eb
Compare
|
bn.js 5 rejects some private keys that bn.js 4 (and elliptic) accepted. The “load_keypair reads keys like elliptic did” test fails with “Invalid character”. BN is also part of the public API (getPrivate returns a BN), so this would be a breaking change for merchants in a minor release. Closing. If we want it, it belongs in the next major version of the SDK. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
@dependabot ignore this major version |
|
OK, I won't notify you about version 5.x.x again, unless you re-open this PR. |
Bumps bn.js from 4.12.5 to 5.2.5.
Release notes
Sourced from bn.js's releases.
Changelog
Sourced from bn.js's changelog.
... (truncated)
Commits
eb2e57c5.2.573fb9a4fix: correct divRound rounding for negative operands (#320)dd84df8fix: normalize sign when imuln multiplies by zero (#321)96f2f815.2.4dc3429ffix: clear surplus words in inotn so notn(width) stays below 2 ** width (#319)ea6c0725.2.333df26bfix imaskn state (#317)6db7c385.2.2c7e1a53Fix imuln/muln with zero (#313)4cc0bfadocs: mention the max plain JS number argument value (#307)