Repository navigation
Develop - #261
Merged
Merged
Develop#261
Conversation
- drawing a Manifold shape sent the whole draw DTO (colours, opacity, back
face and the rest) to decomposeManifoldOrCrossSection and
decomposeManifoldsOrCrossSections, and drawing a JSCAD mesh did the same to
shapeToMesh and shapesToMeshes; the workers' input check warned once for
every field the operation does not take ("faceOpacity is not an input of
this operation and is ignored")
- those fields were part of the worker's cache key too, so a change of
colour or opacity alone decomposed the shape again and cached a second
copy of its mesh; a shape now has one entry however it is drawn
- Babylon.js, three.js and PlayCanvas alike; the draw helper tests hold
each payload exactly
- nightly.yml builds the CAD Cloud SDK, as verify.yml does; without its dist, sheet-metal-unfold and step-to-gltf-cli could not resolve it - smoke:local fails at once, naming the package, when a workspace package it links has no build - ifc-house: a hidden placement is written out field by field instead of spread from the DTO class, which the template's lint refuses (the example and the template it is copied into) - drone-assembly: the logo is aligned to the hatch plane by its bounding box's centre; aligning its minimum, which includes the edge tolerance, left the hatch's holes a tolerance off the plane, and createFaceFromWires now refuses a face that is not valid
- every example's lockfile names 1.6.0-rc.0 - five examples' manifests move to manifold-3d 3.5.4, three.js 0.186.1 or PlayCanvas 2.23.3, the versions their lockfiles were resolved against
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.