Repository navigation
[Feat/#313] 특정 학번 소속 검사 예외 허용 #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
...mber/src/main/java/kr/ac/kookmin/stream/member/domain/member/domain/MemberConfigKeys.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package kr.ac.kookmin.stream.member.domain.member.domain; | ||
|
|
||
| // admin_config_values에 저장되는 회원 관련 키 | ||
| public final class MemberConfigKeys { | ||
|
|
||
| // 소속 검사 없이 가입·로그인을 허용할 학번 목록(콤마 구분) | ||
| public static final String DEPARTMENT_BYPASS_STUDENT_IDS = "MEMBER_DEPARTMENT_BYPASS_STUDENT_IDS"; | ||
|
jjunh33 marked this conversation as resolved.
Resolved
|
||
|
|
||
| private MemberConfigKeys() {} | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[a]리뷰 포인트 주신 전공 문자열 우회 방식에 대한 의견이에요. 지금 범위에서는 괜찮아 보여요.Department.fromMajor는MemberServiceImpl의register·applyProfile에서만 불리고, 그 입구인updateProfile·registerOrUpdateByStudentId를 부르는 곳은 이 UseCase뿐이에요. 다른 경로로 예외가 새거나 빠지는 곳은 없습니다.Department만 저장돼서(Member.create·Member.updateProfile) 바꾼 문자열이 DB에 남지도 않아요.다만
"소프트웨어전공"이Department.SW의majorName(Department.java:17)을 옮겨 적은 값이라 매칭 규칙이 두 곳에 생겨요. 예를 들어SW의majorName을 고치면DEPARTMENT_NOT_ALLOWED로 막히는데, 컴파일에서는 드러나지 않아요.Department에서 값을 꺼내 쓰면 한 곳만 고치면 됩니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
예외 학번에 대해서만 일어나는 일이라서 department 코드 자체를 수정하기보다, 말씀해주신 상황이 생겼을 때는 직접 확인 후 수정하는 방향이 더 적절하다고 생각해서 반영하지 않았습니다!