Repository navigation
fix(scripts): return errors for bad script paths, include stderr on failure - #973
Open
delaysystem wants to merge 1 commit into
Open
delaysystem wants to merge 1 commit into
delaysystem wants to merge 1 commit into
Conversation
…ailure
Script::run unwrapped the script path and its UTF-8 conversion when
{{script}} was used, panicking instead of erroring. Return descriptive
errors instead. Failures also reported only a bare exit code,
discarding the child's stderr that explains them (the opacity behind
bee-san#513); append a trimmed, bounded stderr tail, keeping the historical
message when stderr is empty.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #513 (not claiming its Windows root cause).
Script::runpanicked on bad{{script}}paths, now it returns a descriptive error. Failures used to report a bareExit code = N, now they append a trimmed 500-char stderr tail (message unchanged when stderr is empty).Tests: 5 new unit tests, none spawning processes per contributing.md; full gates green. Untouched: #963's tag-direction code.