Repository navigation
fix(input): make --top respect CLI ports and warn when it has no list - #969
Open
delaysystem wants to merge 1 commit into
Open
delaysystem wants to merge 1 commit into
delaysystem wants to merge 1 commit into
Conversation
--top had two defects: with a config ports list it silently overrode explicit -p/--range, contradicting the CLI-wins rule from bee-san#947; and without a config ports list it silently scanned the full range while the user believed the top ports were scanned. Now explicit CLI ports or range take precedence, and --top with no configured list warns that the full range will be scanned. The --top help text now says where the list comes from.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
--topdefects inOpts::merge_optional:portssilently overrode explicit CLI-p/--range, against the CLI-wins rule from fix(config): let command-line options override the config file #947.--topwith no configured list silently scanned the full range while the user believed it was the top 1000.Now CLI ports/range win, and
--topwith no list warns and scans the full range. The--tophelp text now says where the list comes from.Tests: 5 new merge tests covering all four combinations plus the no-top case; full gates green.