Repository navigation
Conversation
Member
Author
|
i added a protobuf patch here so we can flip this flag for now, but we could also just leave that out and flip the flag after a future protobuf bump |
Member
|
@keith I've just merged a big PR which removes WORKSPACE mode support, any chance you could rebase/merge this? |
For these rules we just need to make sure we use the same exec group for multiple toolchains so they are resolved for the same platform.
keith
force-pushed
the
ks/fix-compatibility-with-incompatible_auto_exec_groups
branch
from
October 14, 2026 07:00
0fe8d88 to
e68effe
Compare
Member
Author
|
thanks, done! |
p0deje
approved these changes
Oct 14, 2026
Member
|
Thanks for the PR! |
Member
Author
|
Thanks! |
keith
deleted the
ks/fix-compatibility-with-incompatible_auto_exec_groups
branch
October 14, 2026 14:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For these rules we just need to make sure we use the same exec group for
multiple toolchains so they are resolved for the same platform.
We can't enable it on CI until protobuf is fixed, we can't fix protobuf until
rules_ruby is fixed and released