Repository navigation
fix(deps): update dependency @hono/node-server to v2.1.6 [security] - #104
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.1.5→2.1.6@hono/node-server: Backslash in the request path is parsed as a path separator, bypassing path-based access control at a reverse proxy
CVE-2026-126210 / GHSA-jpvv-r467-5p4w
More information
Details
Summary
@hono/node-serverpasses the raw request-target to the WHATWG URL parser, which treats a backslash in the path as/and then resolves..segments. A request for/admin\secretor/public\..\admin/secretreaches the application as/admin/secret. A reverse proxy that follows RFC 3986 forwards the backslash unchanged and applies its path-based rules to the original path, so the request reaches a route the proxy is meant to block.Details
A raw backslash is not allowed in a request-target (RFC 3986, RFC 9112 Section 3.2.1), and RFC 9112 Section 3.2 says a recipient should reject such a request rather than correct it. Proxies such as nginx on Linux, HAProxy and Envoy keep the backslash as an ordinary character, so they and the application see different paths.
The fix responds with
400 Bad Requestto a request whose path contains a raw backslash, for HTTP/1.1, HTTP/2, absolute-form request-targets and WebSocket upgrades. A percent-encoded backslash and a backslash in the query string are still accepted.Impact
An unauthenticated client can reach a route that a reverse proxy, load balancer or WAF in front of the application blocks by path.
This affects applications served by
@hono/node-serverbehind a front component that makes path-based decisions and forwards a backslash unchanged. Access control inside the Hono application, such as middleware on/admin/*, runs on the rewritten path and is not affected.Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
@hono/node-server: Unhandled
ECONNRESETon the socket during an asynchronous WebSocket upgrade crashes the processCVE-2026-126343 / GHSA-qv5m-9pm6-hqp3
More information
Details
Summary
While
@hono/node-serverwaits for the Hono application to handle a WebSocket upgrade request, the socket has no error listener. If the client resets the TCP connection during that time, the resultingECONNRESETis emitted as an unhandled'error'event and the process terminates.Details
The upgrade handler awaits the application before attaching any listener to the socket. When middleware on the upgrade path does asynchronous work, such as an authentication lookup, a connection reset in that window has no handler. If a global
uncaughtExceptionhandler swallows the error, the pending upgrade is never released and its entry is retained for the lifetime of the process.The fix attaches error and close listeners to the socket before calling the application, releases the pending upgrade when the socket closes, and skips the handshake on a destroyed socket.
Impact
An unauthenticated client can terminate the server process with a single connection by sending a WebSocket upgrade request and resetting the connection before the application has responded. Where the crash is suppressed, repeated requests grow the heap.
This affects applications that enable WebSocket support in
@hono/node-serverand run asynchronous middleware or handlers on the upgrade path.Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:LReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
honojs/node-server (@hono/node-server)
v2.1.6Compare Source
Security fixes
This release includes fixes for the following security issues:
Backslash in the request path is parsed as a path separator, bypassing path-based access control at a reverse proxy
Affects: all requests. The raw request-target was passed to the WHATWG URL parser, which treats a backslash in the path as
/and resolves..segments, so/admin\secretreached the application as/admin/secret. A reverse proxy that forwards the backslash unchanged applied its path-based rules to the original path. GHSA-jpvv-r467-5p4wA request whose path contains a raw backslash is now rejected with
400 Bad Request, for HTTP/1.1, HTTP/2 and WebSocket upgrades. A percent-encoded backslash (%5C) and a backslash in the query string are still accepted.WebSocket upgrade request-target starting with
//replaces the host inc.req.url, bypassingOriginchecksAffects:
upgradeWebSocket. The URL of an upgrade request was built by resolving the request-target against theHostheader, so a request-target such as//attacker.example/wsset the host ofc.req.urlto a client-chosen value while routing still saw/ws. An application that comparedOriginwith the origin ofc.req.urlcould be bypassed by a page on another site. GHSA-7v5p-43qr-wch5The host of upgrade requests now comes from the
Hostheader, as for ordinary requests.Unhandled
ECONNRESETon the socket during an asynchronous WebSocket upgrade crashes the processAffects:
upgradeWebSocket. While the application handled an upgrade request, the socket had no error listener. A client that reset the connection during asynchronous middleware caused an unhandled'error'event and terminated the process. GHSA-qv5m-9pm6-hqp3Error and close events on the socket are now handled while the application runs, and a pending upgrade is released when the socket closes.
The backslash fix also ships in
@hono/node-serverv1.19.18. Users ofupgradeWebSocketare encouraged to upgrade to this version.Configuration
📅 Schedule: (in timezone America/Chicago)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.