Skip to content

chore(esdk): add knownBugOverrides scaffold to commons-configuration #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kessplas wants to merge 3 commits into
base: lucmcdon/esdk-test-server
Choose a base branch
from
+21 −8
Draft

chore(esdk): add knownBugOverrides scaffold to commons-configuration #1700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0a854e
chore(esdk): split server/feature/bug config into separate files
kessplas Aug 4, 2026
fec2b4e
chore(test-server): read commons coordinates from server-config.json
kessplas Sep 17, 2026
7946c20
fix(test-server): sort the raw AES wrapping AAD by UTF-8 bytes (#1719)
lucasmcdonald3 Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test-server/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ PID_FILE := .server.pid
LOG_FILE := .server.log

# Bootstrap-then-delegate coordinates for `make test-server`. The commons
# repository coordinates live in commons-configuration.json next to this
# repository coordinates live in server-config.json next to this
# Makefile; COMMONS_BRANCH overrides the configured branch at invocation time.
MAKEFILE_DIR := $(abspath $(dir $(lastword $(MAKEFILE_LIST))))
REPO_ROOT := $(abspath $(MAKEFILE_DIR)/..)
COMMONS_CONFIGURATION := $(MAKEFILE_DIR)/commons-configuration.json
COMMONS_CONFIGURATION := $(MAKEFILE_DIR)/server-config.json
COMMONS_BRANCH ?=
CLONE_DIR ?= $(MAKEFILE_DIR)/.commons-clone
CLONE_ORCH_DIR := $(CLONE_DIR)/esdk/test-server/orchestrator
Expand Down
7 changes: 7 additions & 0 deletions test-server/bug-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
[
"decrypt-accepts-trailing-bytes-commit-key",
"create-client-accepts-reserved-aws-kms-namespace",
"encrypt-accepts-reserved-prefix-encryption-context-key",
"encrypt-mishandles-proto-encryption-context-key",
"default-cmm-ignores-reproduced-only-encryption-context"
]
6 changes: 0 additions & 6 deletions test-server/commons-configuration.json → test-server/feature-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
{
"commonsRepository": {
"name": "aws-crypto-tools-commons",
"url": "git@github.com:aws/aws-crypto-tools-commons.git",
"branch": "lucmcdon/esdk-test-server-all-languages"
},
"product": "esdk",
"supportedFeatures": [
"streaming",
"hierarchical",
Expand Down
8 changes: 8 additions & 0 deletions test-server/server-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"commonsRepository": {
"name": "aws-crypto-tools-commons",
"url": "git@github.com:aws/aws-crypto-tools-commons.git",
"branch": "lucmcdon/esdk-test-server-all-languages"
},
"product": "esdk"
}
4 changes: 4 additions & 0 deletions test-server/src/bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ function buildRawAes(config: RawAesKeyringConfig): KeyringNode {
* into the request body. */
unencryptedMasterKey: new Uint8Array(config.wrappingKey),
wrappingSuite,
/* Sort the encryption context by UTF-8 bytes in the wrapping AAD, as the
* other ESDK implementations do. The keyring defaults to the older
* locale order. */
utf8Sorting: true,
})
}

Expand Down
Loading