Skip to content

Github Access Token is redacted before being used. #434

Closed

Description

@nikkoc

When running a deployment where the application is stored in Github, the download fails when using the v2 codedeploy-agent due to Github returning a 401 Unauthorized error. The token used is not expired/bad in any way because it can be used just fine using the v1 codedeploy-agent. The problem seems to stem from the parse_deployment_spec_data function in /src/deployment_specification/parse.rs redacting the token for logging but doing so by changing the value instead of logging a copy of the value.

The unit test does not fail on this because it only fails upon a crash. The GitHub end-to-end test does not catch this either because it directly calls DeploymentSpec::new() instead of DeploymentSpec::parse() that is called in the actual service.

Activity

  1. nathan-inge commented on Nov 3, 2026

    @nathan-inge
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions