Repository navigation
ci(e2e): Run the Box e2e tests on macOS and Linux arm64 runners with the pinned box #2872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: box-integration
Are you sure you want to change the base?
Changes from all commits
978be7e
2c2bb67
c1adcef
c4d53f4
6a48734
bc71015
887297f
5049104
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,8 +26,10 @@ The `box` tests cover the Strands Box templates, which run their agent in a box. | |
| invoke each one on AgentCore Runtime, and run `agentcore dev` with one local invoke for each. They | ||
| are optional and need a `box` on your PATH: `create` checks for one for a CodeZip box template, and | ||
| `build` and `deploy` run `box profile show` for every Box template, the container one too. Without | ||
| one, they skip. `create` also installs the agent's dependencies and the CDK app's, which `dev` and | ||
| `deploy` use, so the tests don't pass `--skip-install`. | ||
| one, they skip. box ships only arm64 builds, so in CI only the macOS runner (Apple silicon) and the | ||
| Linux arm64 runner (`ubuntu-24.04-arm`) have one: each installs the box that | ||
| `src/core/project/backends/boxRelease.json` pins. `create` also installs the agent's dependencies | ||
| and the CDK app's, which `dev` and `deploy` use, so the tests don't pass `--skip-install`. | ||
|
|
||
| The tests that deploy also need `AGENTCORE_E2E_BOX_CDK`: the pinned `@aws/agentcore-cdk` release | ||
| cannot deploy a Box project yet. Set it to an `@aws/agentcore-cdk` version or a `file:` tarball | ||
|
|
@@ -37,8 +39,9 @@ that can, for example one packed from the `box-integration` branch of | |
| `agentcore/cdk`. Without it, as in CI, they skip. | ||
|
|
||
| The `dev` tests also need a machine where `box run` can start its sandbox, and for the container | ||
| template a container tool. Box listens on the protocol's fixed port (8080, 8000 or 9000), so the | ||
| `dev` tests run one at a time and need those ports free: | ||
| template a container tool. The container template's `dev` test skips when no `docker`, `podman` | ||
| or `finch` runs from PATH, as on the CI macOS runner; the Linux arm64 runner runs it. Box listens on the protocol's fixed port (8080, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: this line runs to 133 columns while the rest of the paragraph wraps at 100. Could you rewrap it? One caveat: |
||
| 8000 or 9000), so the `dev` tests run one at a time and need those ports free: | ||
|
|
||
| ```sh | ||
| AGENTCORE_E2E_BOX_CDK=file:/path/to/aws-agentcore-cdk-1.1.0.tgz bun run test:e2e -- --tagsFilter='box' | ||
|
|
@@ -52,7 +55,8 @@ pins a shim for `PYTHON_3_14` only, so they fail on any machine. | |
|
|
||
| The `box-egress` test checks that box, under `agentcore dev`, lets the agent reach the host its | ||
| profile allows (`checkip.amazonaws.com`) and blocks any other (`example.com`). It reaches public | ||
| hosts, so the network can make it fail. It retries twice, and `--tagsFilter='box'` leaves it out: | ||
| hosts, so the network can make it fail. It retries twice, and `--tagsFilter='box'` leaves it out. | ||
| A full run includes it, so in CI it runs on the macOS and Linux arm64 runners: | ||
|
|
||
| ```sh | ||
| bun run test:e2e -- --tagsFilter='box-egress' | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.