Repository navigation
868 bug/resource based inline aggregates failing from differing targets - #272
Merged
Conversation
…ce-based-inline-aggregates-failing-from-differing-targets
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix For Inline First Aggregate Mismatch
Contributor Checklist
Description
This is a fix to address the resource-based inline aggregates (issue 868) for the posgres_sql repository.
Problem
Whenever a guest schema and table are passed into the first macro, the resulting query attempts to look up the guest table from the local schema, resulting in a mismatch followed by a crash. So far, I've observed this only happening with the first macro only.
The cause is that when the query is generated, the guest table name is kept, but the schema is forgotten completely. This causes the guest table to be auto assigned to the local schema instead, resulting in a crash.
calculate :latest_report, :string, expr(first(Report, field: :title, query: [ filter: expr(author_name == parent(name)), sort: [inserted_at: :desc] ] ))Solution
The function resource_to_query in lib/query.ex is now configured with the prefix already assigned to the target schema instead of being set to null. This way, the query generated by this starts out correct and does not need to be corrected later down the line. Any functions that need to override this down the line can still do so.
What this PR Includes
The bug fix in lib/query.ex.
The regression test for this fix can be found here.