Repository navigation
Flatten nested calculation and aggregate select merge bases - #270
Merged
zachdaniel merged 2 commits intoOct 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A selected field-visibility calculation can remain inside an earlier select-merge base when an aggregate is selected afterwards. Ecto rejects the remaining nested calculation map when the query becomes a subquery, including paginated relationship aggregate loads.
Recursively flatten calculation and aggregate maps throughout select-merge expressions and collect every return-field mapping. Preserve merge structure, expression order, select parameters, and metadata.
Tests are committed separately before the source fix. Validation: 27 SQL tests passed; two new regressions fail without the fix. The independent authorized-aggregate branch merges cleanly in either order; both resulting trees are identical and all 32 combined SQL tests pass.
SQLite compatibility: all 307 tests passed on Ash SQLite
88d58bc573ecd425993ee28cc8ac34b34de3a7bcusing only this branch.Integration regression coverage: ash_postgres #886. The test PR is draft and keeps normal dependency requirements unchanged until this fix is available.