Skip to content

feat: EXPKITS-1450 refine pipeline editing and playback UX - #299

Draft
ZachMaso wants to merge 2 commits into
feature/EXPKITS-1450-runtime-opchain-reloadfrom
feature/EXPKITS-1450-playback-controls-top
Draft

ZachMaso wants to merge 2 commits into
feature/EXPKITS-1450-runtime-opchain-reloadfrom
feature/EXPKITS-1450-playback-controls-top

Conversation

@ZachMaso

Copy link
Copy Markdown
Contributor

Goal

Make the runtime model editor easier to discover, edit and review while keeping playback controls accessible. This draft layers the UX changes onto the latest feature/EXPKITS-1450-runtime-opchain-reload revision (690777c), retaining its model-group API and runtime safeguards.

Change

  • Move playback controls and state above the scrolling model list; refine spacing, switch styling and disabled interactions.
  • Introduce Edit Pipeline with Save/Discard for draft additions, replacements, removals and ordering. Hide input, activation and dependency controls while editing.
  • Place icon-only insertion buttons on the dividers and support adding at a specified position within a model group.
  • Restrict dragging to the handle, highlight the actual insertion divider, and use an isolated, rounded, full-height drag preview.
  • Add explanatory tooltips; keep dependency text and inactive-source warnings synchronized with input selections. Embed edit icons to avoid first-use fetch delays.
  • Read current input bindings in model status so dropdown changes are reflected while stopped.
  • Update user documentation and regression coverage. The local demo pipeline and media are excluded.

Save applies edits sequentially, not atomically. If an edit fails, the UI returns to the server model list and explains that earlier saved changes may have applied. Session edits do not persist pipeline presets.

Testing

  • Rebased onto 690777c; native Meson build passed in the existing ARM64 build container.
  • npm test --prefix development/web: 117 browser tests and 28 FrameResults tests passed.
  • Focused model-editor and Wafer tests passed; generated bundle consistency and git diff --check passed.
  • opk-ci --pre-commit-check passed for all 13 changed files using a temporary tool environment. Several pinned dependency versions were unavailable, so available versions were used for those tools; clang-format matched the repository's pinned 23.1.5.
  • Live local verification on the rebased runtime: additions at positions 0, 2 and end, correct metadata for the inserted model, removal/restoration, stopped input selection and disconnection, model-picker discovery, and queued Save/reordering. Existing model order, inputs and activation states restored.
  • The standalone native WebSocket regression test could not run because the container lacks Python gi; the full native suite was not run.

Draft for developer review and further UX testing; not ready to merge.

Task: EXPKITS-1450
Signed-off-by: Zach Mason <270372262+ZachMaso@users.noreply.github.com>
Task: EXPKITS-1450
Signed-off-by: Zach Mason <270372262+ZachMaso@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant