[Dor-bl]

Changes

appium/webdriver/appium_service.py: replace the hand-rolled PATH search in find_executable with shutil.which.
test/unit/webdriver/appium_service_test.py: add a unit test for it.

Testing

pytest test/unit/webdriver/appium_service_test.py: 5 passed.

[mykola-mokhnach]

find_executable is now a one-line wrapper over shutil.which, so get_node() and get_npm() could call shutil.which directly. That would let us drop the wrapper, along with the find_executable asserts around line 333. It's optional, since keeping the wrapper is also fine. On Windows, get_npm() can also pass plain 'npm' instead of 'npm.cmd', because which resolves it via PATHEXT.

[Dor-bl]

Updated: dropped find_executable and called shutil.which('node') / shutil.which('npm') directly in get_node() and get_npm().