Repository navigation
Conversation
A custom audit logger can throw while closeSession is deleting ephemeral nodes. Catch RuntimeException and LinkageError at the audit call so cleanup finishes and lastProcessedZxid advances. Report the failure in the regular log. Add regression coverage for both closeSession paths, repeated audit failures, and missing nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exception from a custom audit logger could leave closeSession partially applied and put the server into ERROR. DataTree now catches RuntimeException and LinkageError from audit writes, reports the failure in the regular log, and completes ephemeral cleanup.
Regression tests cover both closeSession paths, repeated failures, and missing nodes.