Repository navigation
ZOOKEEPER-5097: Make DataTree snapshot serialization iterative - #2476
Merged
Merged
Conversation
PDavid
approved these changes
Oct 16, 2026
PDavid
left a comment
PDavid
left a comment
Contributor
There was a problem hiding this comment.
Many thanks. 👍
Special thanks for adding the test for it.
kezhuw
approved these changes
Oct 20, 2026
…aTreeTest.java Assertion failure will report the exception anyway Co-authored-by: Kezhu Wang <kezhuw@gmail.com>
Contributor
Author
anmolnar
added a commit
that referenced
this pull request
Oct 21, 2026
Reviewers: PDavid, kezhuw Author: anmolnar Closes #2476 from anmolnar/ZOOKEEPER-5097
anmolnar
added a commit
that referenced
this pull request
Oct 21, 2026
Reviewers: PDavid, kezhuw Author: anmolnar Closes #2476 from anmolnar/ZOOKEEPER-5097
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataTree.serializeNode walked the tree recursively, one frame per znode
level, which does not scale to very deep trees. Rewrite it as an iterative
pre-order traversal over an explicit heap stack, removing the dependency on
tree depth. Traversal order, per-node locking and emitted records are
unchanged, so the on-disk snapshot format is identical. Adds a regression
test that serializes a very deep chain on a small-stack thread and checks it
round-trips.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com