Repository navigation
[ZEPPELIN-6751] Prevent automatic image requests in AI Assistant answers - #5572
Merged
voidmatcha merged 2 commits intoOct 16, 2026
Merged
Conversation
miinhho
force-pushed
the
assistant-image-loading-policy
branch
from
October 16, 2026 14:20
be7606d to
05a05e0
Compare
voidmatcha
changed the base branch from
branch-voidmatcha-assistant-storybook-temp
to
master
October 16, 2026 14:21
Member
|
@miinhho #5570 is merged, so I switched the base to That leaves only your two image-policy commits and 9 files, with no conflicts. Please also drop the "Depends on #5570" line from the description. I'll review it after that. |
miinhho
force-pushed
the
assistant-image-loading-policy
branch
from
October 16, 2026 14:24
05a05e0 to
fa04b2c
Compare
voidmatcha
approved these changes
Oct 16, 2026
Member
|
Merged into master (0d344fb). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Addresses the image-loading follow-up raised in #5570.
Model-generated Markdown can include image URLs containing notebook data. Loading these images automatically sends a request to the destination without user interaction.
This PR replaces automatic image loading with a Load image button. Before loading, the reader can review the image description, destination host, full URL, and a warning that the request may transmit information from the answer. Only HTTP(S) image URLs are supported.
Approval is specific to each image in an answer. Unchanged images retain approval during streaming, including when a reference definition gains a title. Changing the destination or removing and restoring an image requires fresh approval.
What type of PR is it?
Bug Fix
What is the Jira issue?
How should this be tested?
From
zeppelin-web-angular/projects/zeppelin-react, run:npm test -- src/entities/assistant/ui/MarkdownAnswer.spec.tsx npm run typecheck npm run build:storybook npm run test:storybook -- markdown-answer-images.spec.mjsFor manual verification, run
npm run storybookand open Assistant / MarkdownAnswer:contentcontrol, remove an approved image and restore the same Markdown. Confirm that it requires approval again.Questions