Skip to content

THRIFT-6473: Raise the WinGet manifest version to 1.28.0 - #4068

Merged
Jens-G merged 1 commit into
apache:masterfrom
Jens-G:THRIFT-6473
Nov 12, 2026
Merged

Jens-G merged 1 commit into
apache:masterfrom
Jens-G:THRIFT-6473

Conversation

@Jens-G

@Jens-G Jens-G commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

THRIFT-6473

The submit job downloads the latest wingetcreate release. Since 2026-11-11 that is v1.28.1.0, which contains microsoft/winget-create#711 and validates with WinGetUtil 1.29.380: a 1.28.0 manifest is checked against the 1.28.0 schemas. The release before it, 1.12.13.0 (WinGetUtil 1.12.350), checked such a manifest against the 1.12.0 schema and rejected its $schema comment, so wingetcreate submit would have opened no pull request and the job would have failed. This pull request was a draft until that release.

winget-pkgs flagged the 0.25.0 submission, microsoft/winget-pkgs#445370, on 2026-10-30: manifest version 1.12.0 is deprecated, and 1.28.0 is to be used instead. The templates on master still name 1.12.0, so the 0.26.0 submission would be flagged the same way. The manifests in that pull request were moved to 1.28.0 on its branch, and it was merged on 2026-11-10.

Changes

  • The three templates in build/windows/winget/: ManifestVersion and the $schema comment move to 1.28.0. No field changes: of the three schemas the package uses, only the installer schema gains a field between 1.12.0 and 1.28.0, the optional DesiredStateConfiguration, which the package does not use.
  • test-winget-manifests.ps1 checks that each $schema comment names the type and version of the manifest under it, and that the three manifests share one version. WinGet's validation rejects a manifest whose comment and fields disagree, so a bump that misses one of the six lines now fails here first.
  • build/windows/README.md: where the version is set, and to raise it only to a version the latest wingetcreate release knows.

Verification

  • All 28 checks of test-winget-manifests.ps1 pass, on master's templates and on the raised ones (24 before this change). With only ManifestVersion raised in Apache.Thrift.yaml.in, two checks fail; with only the installer's $schema comment raised, one fails.
  • Rendered for 0.25.0 with -InstallerSource github, the three manifests pass validate_manifests.py against the WinGet 1.28.0 schemas. Parsed, they match the manifests merged with Apache.Thrift version 0.25.0 microsoft/winget-pkgs#445370, apart from MinimumVersion: '14.51' (THRIFT-6401, which came after that submission).
  • The wingetcreate points above are read, not run, as wingetcreate needs Windows: from the sources of wingetcreate v1.12.13.0 and v1.28.1.0 and of winget-cli v1.12.350 and v1.29.380, and from the WinGetUtil 1.29.380 binary on NuGet, which embeds the three 1.28.0 schema IDs. The $id of the default-locale schema is spelled defaultlocale; WinGetUtil compares it with the $schema comment case-insensitively. The submit command line and the token handling are the same in both wingetcreate releases.
  • Re-run after rebasing onto master (6050f83e1) on 2026-11-12: the 28 checks pass, and the rendered 0.25.0 manifests validate and match the merged ones, $schema comments included, apart from MinimumVersion.

🤖 Generated with Claude Code

@mergeable mergeable Bot added the build and general CI cmake, automake and build system changes label Oct 30, 2026
Client: build

winget-pkgs flags manifest version 1.12.0 as deprecated and asks for
1.28.0, as it did for the 0.25.0 submission. The three templates move
to 1.28.0, in ManifestVersion and in the $schema comment. No field
changes: of the three schemas the package uses, only the installer
schema gains a field, the optional DesiredStateConfiguration, which
the package does not use.

test-winget-manifests.ps1 now checks that each $schema comment names
the type and version of the manifest under it, and that the three
manifests share one version, as WinGet's own validation requires.
build/windows/README.md says where the version is set and what to
check before raising it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Jens-G
Jens-G marked this pull request as ready for review November 12, 2026 21:40
@Jens-G
Jens-G merged commit 149c66d into apache:master Nov 12, 2026
99 of 100 checks passed
@Jens-G
Jens-G deleted the THRIFT-6473 branch November 12, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build and general CI cmake, automake and build system changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant