Repository navigation
THRIFT-6473: Raise the WinGet manifest version to 1.28.0 - #4068
Merged
Merged
Conversation
Client: build winget-pkgs flags manifest version 1.12.0 as deprecated and asks for 1.28.0, as it did for the 0.25.0 submission. The three templates move to 1.28.0, in ManifestVersion and in the $schema comment. No field changes: of the three schemas the package uses, only the installer schema gains a field, the optional DesiredStateConfiguration, which the package does not use. test-winget-manifests.ps1 now checks that each $schema comment names the type and version of the manifest under it, and that the three manifests share one version, as WinGet's own validation requires. build/windows/README.md says where the version is set and what to check before raising it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THRIFT-6473
The submit job downloads the latest
wingetcreaterelease. Since 2026-11-11 that is v1.28.1.0, which contains microsoft/winget-create#711 and validates with WinGetUtil 1.29.380: a 1.28.0 manifest is checked against the 1.28.0 schemas. The release before it, 1.12.13.0 (WinGetUtil 1.12.350), checked such a manifest against the 1.12.0 schema and rejected its$schemacomment, sowingetcreate submitwould have opened no pull request and the job would have failed. This pull request was a draft until that release.winget-pkgs flagged the 0.25.0 submission, microsoft/winget-pkgs#445370, on 2026-10-30: manifest version 1.12.0 is deprecated, and 1.28.0 is to be used instead. The templates on master still name 1.12.0, so the 0.26.0 submission would be flagged the same way. The manifests in that pull request were moved to 1.28.0 on its branch, and it was merged on 2026-11-10.
Changes
build/windows/winget/:ManifestVersionand the$schemacomment move to 1.28.0. No field changes: of the three schemas the package uses, only the installer schema gains a field between 1.12.0 and 1.28.0, the optionalDesiredStateConfiguration, which the package does not use.test-winget-manifests.ps1checks that each$schemacomment names the type and version of the manifest under it, and that the three manifests share one version. WinGet's validation rejects a manifest whose comment and fields disagree, so a bump that misses one of the six lines now fails here first.build/windows/README.md: where the version is set, and to raise it only to a version the latestwingetcreaterelease knows.Verification
test-winget-manifests.ps1pass, on master's templates and on the raised ones (24 before this change). With onlyManifestVersionraised inApache.Thrift.yaml.in, two checks fail; with only the installer's$schemacomment raised, one fails.-InstallerSource github, the three manifests passvalidate_manifests.pyagainst the WinGet 1.28.0 schemas. Parsed, they match the manifests merged with Apache.Thrift version 0.25.0 microsoft/winget-pkgs#445370, apart fromMinimumVersion: '14.51'(THRIFT-6401, which came after that submission).wingetcreatepoints above are read, not run, aswingetcreateneeds Windows: from the sources of wingetcreate v1.12.13.0 and v1.28.1.0 and of winget-cli v1.12.350 and v1.29.380, and from the WinGetUtil 1.29.380 binary on NuGet, which embeds the three 1.28.0 schema IDs. The$idof the default-locale schema is spelleddefaultlocale; WinGetUtil compares it with the$schemacomment case-insensitively. Thesubmitcommand line and the token handling are the same in bothwingetcreatereleases.6050f83e1) on 2026-11-12: the 28 checks pass, and the rendered 0.25.0 manifests validate and match the merged ones,$schemacomments included, apart fromMinimumVersion.🤖 Generated with Claude Code