Repository navigation
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Xinyuan Lin <xinyual3@uci.edu>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…xera into test/file-saver-service-spec
Updates the branch to current main and carries its single net change, a Vitest spec for FileSaverService. - FileSaverService is a thin wrapper whose saveAs(data, filename?, options?) forwards straight to the file-saver library's saveAs; the spec mocks that library and asserts the call is forwarded unchanged. It covers a Blob payload passed through with its filename and options, a string payload such as a URL passed through, omitted filename and options arriving as undefined, and an error thrown by saveAs propagating to the caller instead of being swallowed.
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9045 +/- ##
============================================
+ Coverage 91.87% 91.93% +0.06%
+ Complexity 5048 5046 -2
============================================
Files 1265 1273 +8
Lines 54915 55266 +351
Branches 6940 6989 +49
============================================
+ Hits 50452 50810 +358
+ Misses 2769 2763 -6
+ Partials 1694 1693 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Please fix the ci. |
… delegate
FileSaverService holds its reference to file-saver's `saveAs` in a
`protected saveAsFn` instance property that defaults to
`FileSaver.saveAs`, and its public `saveAs(data, filename?, options?)`
calls `this.saveAsFn(data, filename, options)`. Routing the one call-out
through an own property gives tests a boundary they can replace per
instance, without touching the file-saver module.
The spec injects FileSaverService via TestBed, assigns a fresh `vi.fn()`
to the instance's `saveAsFn` in `beforeEach`, and drives the public
`saveAs`: it checks the service is created, that a Blob payload is
forwarded with its filename and options, that a string payload passes
through unchanged, that an omitted filename and options arrive as
`undefined`, and that an error thrown by `saveAsFn` propagates out of
`saveAs` rather than being swallowed.
Replacing the instance property is independent of module resolution and
bundling, unlike the previous `vi.mock("file-saver")`, which did not
reach the copy the service imports once the runner bundled the CommonJS
module across the full suite.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
FileSaverService, the thin wrapper whosesaveAs(data, filename?, options?)forwards straight to thefile-saverlibrary'ssaveAs.file-saverlibrary so the suite can assert the call is forwarded unchanged: a Blob payload passes through with its filename and options, and a string payload (such as a URL) passes through.undefined, and that an error thrown by the underlyingsaveAspropagates to the caller instead of being swallowed.Any related issues, documentation, discussions?
Closes: #6448
Supersedes #6460, which the stale bot auto-closed for inactivity. The branch is now merged up to current
main.How was this PR tested?
cd frontend && npx ng test --include="**/file-saver.service.spec.ts" --watch=false, expect the FileSaverService suite to pass.saveAsunchanged, an omitted filename and options arrive asundefined, and a thrown error surfaces to the caller.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF