Skip to content

feat(build): resolve all npm audit findings on 22 Nov 2026 - #46459

Open
hainenber wants to merge 3 commits into
masterfrom
fix/resolve-all-npm-audit-findings
Open

hainenber wants to merge 3 commits into
masterfrom
fix/resolve-all-npm-audit-findings

Conversation

@hainenber

Copy link
Copy Markdown
Contributor

feat(build): resolve all npm audit findings on 22 Nov 2026

SUMMARY

Resolves all npm audit findings in superset-frontend. I only override major version for transive deps used in development such as glob. Runtime deps like cheerio.undici is only updated to next minor version

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Green CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
},
"core-js": "^3.38.1",
"fast-xml-parser": "^5.8.0",
"glob": "^14.0.2",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: glob 14 removes the legacy .sync() API, but both checker scripts call glob.sync; running either check script fails instead of enumerating files.

Assessment: 🟠 Major · 🔁 Occurrence: Sometimes · 🏷️ Api mismatch

Use CodeAnt Skill Fix in Cursor Fix in VSCode Claude

Prompt for AI Agent 🤖
This is a comment left during a code review.

**Path:** superset-frontend/package.json
**Line:** 370:370
**Comment:**
	*Api Mismatch: `glob` 14 removes the legacy `.sync()` API, but both checker scripts call `glob.sync`; running either check script fails instead of enumerating files.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in 8981342

@codeant-ai-for-open-source

codeant-ai-for-open-source Bot commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; both checker scripts use Node's fs.globSync, so the reported glob.sync incompatibility is resolved in the current code.

Assessed commit: 8981342a47fe

@codecov

codecov Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.92%. Comparing base (5ef84de) to head (8981342).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #46459   +/-   ##
=======================================
  Coverage   85.92%   85.92%           
=======================================
  Files        3122     3122           
  Lines      216903   216903           
  Branches    51423    51423           
=======================================
+ Hits       186380   186381    +1     
+ Misses      27106    27105    -1     
  Partials     3417     3417           
Flag Coverage Δ
javascript 82.75% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: hainenber <dotronghai96@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant