Repository navigation
Conversation
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
| }, | ||
| "core-js": "^3.38.1", | ||
| "fast-xml-parser": "^5.8.0", | ||
| "glob": "^14.0.2", |
Contributor
There was a problem hiding this comment.
Suggestion: glob 14 removes the legacy .sync() API, but both checker scripts call glob.sync; running either check script fails instead of enumerating files.
Assessment: 🟠 Major · 🔁 Occurrence: Sometimes · 🏷️ Api mismatch
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** superset-frontend/package.json
**Line:** 370:370
**Comment:**
*Api Mismatch: `glob` 14 removes the legacy `.sync()` API, but both checker scripts call `glob.sync`; running either check script fails instead of enumerating files.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #46459 +/- ##
=======================================
Coverage 85.92% 85.92%
=======================================
Files 3122 3122
Lines 216903 216903
Branches 51423 51423
=======================================
+ Hits 186380 186381 +1
+ Misses 27106 27105 -1
Partials 3417 3417
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: hainenber <dotronghai96@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(build): resolve all npm audit findings on 22 Nov 2026
SUMMARY
Resolves all
npm auditfindings insuperset-frontend. I only override major version for transive deps used in development such asglob. Runtime deps likecheerio.undiciis only updated to next minor versionBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Green CI
ADDITIONAL INFORMATION