Skip to content

fix(a11y): name the semantic view description input - #46458

Draft
mikebridge wants to merge 1 commit into
apache:masterfrom
mikebridge:fix-semantic-view-description-label
Draft

mikebridge wants to merge 1 commit into
apache:masterfrom
mikebridge:fix-semantic-view-description-label

Conversation

@mikebridge

Copy link
Copy Markdown
Member

SUMMARY

The semantic view edit dialog shows a Description label, but the textarea has no accessible name. This gives the textarea the same translated name, so assistive technology and label-based interaction can identify it.

The fix is local to the modal; the shared form-field component and save behavior are unchanged.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual layout change. Before, the textarea had no accessible name; after, its name is Description.

TESTING INSTRUCTIONS

  • Added an accessible-name regression test that failed before the fix.
  • All 18 SemanticViewEditModal Jest tests pass; changed-file hooks pass.
  • The full frontend type check has a pre-existing failure in an unrelated Partition test.
  • Open a semantic view's edit dialog and verify that the Description textarea can be located by its accessible name and edited.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: SEMANTIC_LAYERS
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov

codecov Bot commented Nov 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.92%. Comparing base (5ef84de) to head (70d8aec).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #46458      +/-   ##
==========================================
- Coverage   85.92%   85.92%   -0.01%     
==========================================
  Files        3122     3122              
  Lines      216903   216903              
  Branches    51423    51423              
==========================================
- Hits       186380   186374       -6     
- Misses      27106    27112       +6     
  Partials     3417     3417              
Flag Coverage Δ
javascript 82.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant