Repository navigation
fix(a11y): name the semantic view description input - #46458
Draft
mikebridge wants to merge 1 commit into
Draft
mikebridge wants to merge 1 commit into
mikebridge wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #46458 +/- ##
==========================================
- Coverage 85.92% 85.92% -0.01%
==========================================
Files 3122 3122
Lines 216903 216903
Branches 51423 51423
==========================================
- Hits 186380 186374 -6
- Misses 27106 27112 +6
Partials 3417 3417
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The semantic view edit dialog shows a Description label, but the textarea has no accessible name. This gives the textarea the same translated name, so assistive technology and label-based interaction can identify it.
The fix is local to the modal; the shared form-field component and save behavior are unchanged.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No visual layout change. Before, the textarea had no accessible name; after, its name is Description.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION