Skip to content

feat(ci): replace action-validator with actively maintained kjanat/actionlint for GHA workflow static check - #45167

Open
hainenber wants to merge 9 commits into
masterfrom
feat/replace-action-validator-with-a-more-active-maintained-alternative
Open

hainenber wants to merge 9 commits into
masterfrom
feat/replace-action-validator-with-a-more-active-maintained-alternative

Conversation

@hainenber

Copy link
Copy Markdown
Contributor

feat(ci): replace action-validator with actively maintained kjanat/actionlint for GHA workflow static check

SUMMARY

Very much self-titled as we're moving from action-validator to a more actively maintained kjaneat/actionlint that also support for newer GHA syntax such parallel keyword.

This PR also removes a seemingly unused bump-python-package workflow.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Green CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…/actionlint` for GHA workflow static check

Signed-off-by: hainenber <dotronghai96@gmail.com>
@netlify

netlify Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 5f92add
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6b027c0d7eb7245613bbbb07
😎 Deploy Preview https://deploy-preview-45167--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment on lines +37 to +38
- name: Setup Go
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: No go-version or go-version-file is supplied, so setup-go fails before the install step and this validation job never runs.

Assessment: 🟠 Major · 🔁 Occurrence: Often · 🏷️ Api mismatch

Use CodeAnt Skill Fix in Cursor Fix in VSCode Claude

Prompt for AI Agent 🤖
This is a comment left during a code review.

**Path:** .github/workflows/github-action-validator.yml
**Line:** 37:38
**Comment:**
	*Api Mismatch: No `go-version` or `go-version-file` is supplied, so `setup-go` fails before the install step and this validation job never runs.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎

@codeant-ai-for-open-source

codeant-ai-for-open-source Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

CodeAnt  CodeAnt PR Risk

🟡  Medium Risk

  • The PR needs attention before merging because the workflow validation job will fail: Setup Go has no Go version or version file configured.

Assessed commit: 94bd0f0540b0

@codecov

codecov Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.92%. Comparing base (5ef84de) to head (94bd0f0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #45167   +/-   ##
=======================================
  Coverage   85.92%   85.92%           
=======================================
  Files        3122     3122           
  Lines      216903   216903           
  Branches    51423    51423           
=======================================
+ Hits       186380   186381    +1     
+ Misses      27106    27105    -1     
  Partials     3417     3417           
Flag Coverage Δ
hive 33.88% <ø> (ø)
mysql 51.55% <ø> (ø)
postgres 51.58% <ø> (-0.01%) ⬇️
presto 35.55% <ø> (ø)
python 88.42% <ø> (ø)
sqlite 51.26% <ø> (ø)
unit 83.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- name: Test docs-deploy freshness gate
run: bash .github/workflows/scripts/check-docs-deploy-freshness.test.sh
- name: Static check for GHA workflows
run: actionlint

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written, actionlint runs ShellCheck over every run: block and this repo doesn't pass that baseline: the validate-all-ghas job on this head exits 1 here with ~49 ShellCheck diagnostics (e.g. SC2086 in docker.yml/chromatic.yml, an SC1072 error in release.yml:42) plus a real one at superset-frontend.yml:113, where needs.frontend-build isn't in report-coverage's needs. Because the zizmor step comes after this one, a red lint also stops the security audit from running at all. Is the intent to land the ShellCheck/workflow fixes in this PR, or to start with something like actionlint -shellcheck= (or an -ignore list) and tighten later?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have all ShellCheck fixes landing in this PR, we definitely needs a good revamp against increasingly dangerous supply chain risks out there.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. At this head the actionlint step still exits non-zero, which also keeps the zizmor step from running, so this stays open until the fixes are pushed. Can you ping here once they are in?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, all addressed in fd613e5. I had to ignore the lint issues with Node 12 for pr-lint-action and cached-dependencies submoduled action since the only migration is to update them to Node LTS and/or migrate away to a ASF-whitelisted one.


- name: Test docs-deploy freshness gate
run: bash .github/workflows/scripts/check-docs-deploy-freshness.test.sh
- name: Static check for GHA workflows

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This narrows what gets validated: the deleted script checked every tracked .github/workflows/* and .github/actions/* YAML file, whereas actionlint only follows workflows and the local actions they reference, and doesn't lint a composite action's own action.yml. A broken or unreferenced composite action could now merge with a green job. Is that coverage loss acceptable, or should the composite actions get a separate check?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check if there is an option to handle composite actions as well

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. Until a check covers the standalone composite actions, a broken action.yml that no workflow references can merge with a green job. Can you share what you find once you've looked at the options?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this feature only lands at v2. I guess we'll need to wait a bit until said version is released.

@github-actions github-actions Bot added the requires:rebase Requires rebasing on top of current master label Oct 15, 2026
@hainenber

Copy link
Copy Markdown
Contributor Author

Move this back to draft as I'm a bit occupied

@hainenber
hainenber marked this pull request as draft November 2, 2026 15:43
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
hainenber marked this pull request as ready for review November 14, 2026 08:26

@rusackas rusackas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hainenber, nice to see the ShellCheck cleanup land alongside the linter swap. The report-coverage needs fix and the stray quote in release.yml are good catches.

Couple of things before this goes in... A few of the new quotes change behavior rather than just quieting ShellCheck. PLATFORM_ARG holds --platform linux/amd64 (two words), so quoting it hands supersetbot a single argument, and the quoted git tag -d "$(...)" breaks as soon as there's more than one trigger- tag. Suggestions inline for both.

Also, I'm a little wary of installing the linter from a personal fork through a vanity import path, pinned by tag only. Is there something we need from kjanat/actionlint that upstream rhysd/actionlint doesn't have yet?

GitHub shows conflicts, and the validator workflow has moved a fair bit on master, so CI hasn't run on the latest commit. Would you mind rebasing so we can see actionlint pass?

Comment thread .github/workflows/docker.yml Outdated
Comment on lines +415 to +421
if env -u DOCKERHUB_TOKEN supersetbot docker \
"$PUSH_OR_LOAD" \
--preset "$BUILD_PRESET" \
--context "$BUILD_CONTEXT" \
--context-ref "$BUILD_CONTEXT_REF" \
--extra-flags "$EXTRA_FLAGS" \
$PLATFORM_ARG; then
"$PLATFORM_ARG"; then

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLATFORM_ARG is --platform linux/amd64 (or two --platform pairs on master pushes) per scripts/docker-build-plan.sh, so it needs to word-split. Maybe keep these two unquoted and silence SC2086 here?

Suggested change
if env -u DOCKERHUB_TOKEN supersetbot docker \
"$PUSH_OR_LOAD" \
--preset "$BUILD_PRESET" \
--context "$BUILD_CONTEXT" \
--context-ref "$BUILD_CONTEXT_REF" \
--extra-flags "$EXTRA_FLAGS" \
$PLATFORM_ARG; then
"$PLATFORM_ARG"; then
# shellcheck disable=SC2086 # PUSH_OR_LOAD and PLATFORM_ARG are flag lists that must word-split
if env -u DOCKERHUB_TOKEN supersetbot docker \
$PUSH_OR_LOAD \
--preset "$BUILD_PRESET" \
--context "$BUILD_CONTEXT" \
--context-ref "$BUILD_CONTEXT_REF" \
--extra-flags "$EXTRA_FLAGS" \
$PLATFORM_ARG; then

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Evan but unfortunately I can't commit your suggestion here due to it being made from deleted lines :(

Either way, I've addressed in 3a7403c8e12b391fddb6e1cd6577f603dc6b7736

Comment thread .github/workflows/release.yml Resolved
Comment thread .github/workflows/release.yml Resolved
@hainenber

Copy link
Copy Markdown
Contributor Author

Also, I'm a little wary of installing the linter from a personal fork through a vanity import path, pinned by tag only. Is there something we need from kjanat/actionlint that upstream rhysd/actionlint doesn't have yet?

I do share this wariness with you, Evan. However, the upstream has been almost abandoned and many newly introduced GHA syntaxes like $./ or parallel are only covered by the fork. If you checked the pitching issue, there have been many adoption!

…active-maintained-alternative

Signed-off-by: hainenber <dotronghai96@gmail.com>
…branch

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
hainenber force-pushed the feat/replace-action-validator-with-a-more-active-maintained-alternative branch from e01d965 to 3a7403c Compare November 21, 2026 17:14
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
…upersetbot_dry_run`

Signed-off-by: hainenber <dotronghai96@gmail.com>
@github-actions github-actions Bot removed the requires:rebase Requires rebasing on top of current master label Nov 21, 2026
hainenber and others added 2 commits November 22, 2026 12:22
Signed-off-by: hainenber <dotronghai96@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants