Repository navigation
Conversation
…sture Signed-off-by: hainenber <dotronghai96@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45155 +/- ##
==========================================
- Coverage 85.92% 84.72% -1.21%
==========================================
Files 3122 3077 -45
Lines 216903 199596 -17307
Branches 51423 48060 -3363
==========================================
- Hits 186380 169113 -17267
- Misses 27106 27444 +338
+ Partials 3417 3039 -378
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
EnxDev
left a comment
There was a problem hiding this comment.
CI is green with it, and none of the root or workspace package.json files define a pre or post script that would stop running, so the build itself looks unaffected.
One thing inline that I think needs a conscious decision before this merges.
| @@ -1 +1,2 @@ | |||
| min-release-age=3 | |||
| ignore-scripts=true | |||
There was a problem hiding this comment.
This also turns off the @scarf/scarf postinstall, which is how the npm-install telemetry described in the FAQ (the Scarf section of docs/docs/faq.mdx) gets collected. It's a direct dependency with scarfSettings in package.json, so that looks deliberate.
Fine if the project is happy to lose that signal, but it should be a decision and not a side effect. If it goes, the FAQ wants updating in the same PR.
There was a problem hiding this comment.
That's actually a good point there, thanks @EnxDev!
npm 12 will disable install scripts by default) so I guess I'm doing a bit of premature future-proofing here.
I've created scarf-sh/scarf-js#84 so that maybe in the future, they'll find a way to migrate off postinstall script
Wdyt @rusackas? I'm happy with closing this PR since having telemetry collected is still crucial, I understand that.
|
Closing for now to avoid noises |
|
Reopen again as we need to harden up the project. |
sec(build): ignore install scripts in dev deps for better security posture
SUMMARY
Most of listed packages having install scripts are
devDepsin nature, except forcore-js-*which is still runnable if install script is not allowed as it's wrapped in try-catch.To bettering the project's supply chain security, it's better to just ignore install scripts coming from all deps.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Green CI
ADDITIONAL INFORMATION