[Mohit20057]

What is the purpose of the change

Sub-task of umbrella issue #8994 ("inventory deprecated API and remove what is marked for removal").

Classifies surviving @Deprecated APIs and utilities in storm-server, storm-hdfs, and storm-client by upgrading plain @Deprecated annotations to include explicit since = "..." versions and forRemoval decisions, and documents supported replacements in Javadoc:

• storm-server:
  • SchedulerAssignmentImpl.assign(WorkerSlot, Collection): @Deprecated(since = "2.0.0", forRemoval = true) (use overload with WorkerResources).
  • Testing.java (10 testing harness methods): @Deprecated(since = "2.0.0", forRemoval = true) (use LocalCluster.Builder, SimulatedTime, TrackedTopology).
  • BaseResourceAwareStrategy.NodeSortType.GENERIC_RAS and DEFAULT_RAS: @Deprecated(since = "2.3.0", forRemoval = false) (retained for compatibility with *Old strategies; use COMMON).
  • GenericResourceAwareStrategyOld and DefaultResourceAwareStrategyOld: @Deprecated(since = "2.3.0", forRemoval = false) (use GenericResourceAwareStrategy / DefaultResourceAwareStrategy).
  • NodeSorter / NodeSorterHostProximity: documented private helper methods with @deprecated Javadoc.
• storm-hdfs:
  • Configs.java (12 HDFS Spout config key constants): @Deprecated(since = "2.0.0", forRemoval = true) (configure via spout builders).
  • HdfsState.HdfsFileOptions#addRotationAction: @Deprecated(since = "1.0.0", forRemoval = false) (retained for backwards compatibility).
• storm-client:
  • LinearDRPCTopologyBuilder#addBolt(IRichBolt, ...): @Deprecated(forRemoval = true).
  • StormMetricRegistry#gauge(String, Gauge, String, String, Integer, Integer): @Deprecated(since = "2.3.0", forRemoval = true).
  • StormReporter#prepare(MetricRegistry, Map, Map): @Deprecated(since = "2.3.0", forRemoval = true).
  • SASL plain test auth classes (PlainClientCallbackHandler, PlainSaslTransportPlugin, SaslPlainServer): @Deprecated(since = "2.0.0", forRemoval = true).

How was this tested

• Built and compiled all touched modules with JDK 23 (mvn test-compile -pl storm-client,storm-server,external/storm-hdfs,flux/flux-core)
• Checkstyle validated with 0 violations

[reiabreu]

This review was generated with the help of an LLM (Claude) and reviewed by me before posting.

Claude spot-checked the new since values against git history. 12 of the 14 files match; the two below do not.

[rzo1]

@Mohit20057 friendly ping: could you have a look at @reiabreu's review? Two of the since values (HdfsState#addRotationAction and the two LinearDRPCTopologyBuilder#addBolt methods) don't match the git history yet. Thanks!

[Mohit20057]

Hi @rzo1 @reiabreu,

Thank you for checking the git history! In the latest commit:

• HdfsState#addRotationAction has been corrected to @Deprecated(since = "1.0.0", forRemoval = true).
• Both LinearDRPCTopologyBuilder#addBolt overloads have been updated to @Deprecated(forRemoval = true) without the inaccurate since = "2.0.0".

[rzo1]

Thanks, the since values I checked all match the tags now.

Two decisions I'd question:

1. HdfsFileOptions.addRotationAction is marked forRemoval=true without a replacement, while the feature still works and the SequenceFileOptions variant is not deprecated and is documented in storm-hdfs.md. Maybe forRemoval=false, or a short rationale?
2. NodeSortType.GENERIC_RAS/DEFAULT_RAS are marked for removal, but the public *ResourceAwareStrategyOld classes that use them are not deprecated. Should those be deprecated too?

The description still mentions the old since values and getStatus, which no longer match the diff. Nit: forRemoval on private members (e.g. in Flux, NodeSorter) has no effect for API users. The conflicts are from #9184 and look trivial.

[Mohit20057]

@rzo1 Thanks for the review! I have updated the branch to address all the points:

1. HdfsFileOptions#addRotationAction: Updated to @Deprecated(since = "1.0.0", forRemoval = false) with updated Javadoc noting it is retained for backwards compatibility.
2. BaseResourceAwareStrategy.NodeSortType (GENERIC_RAS, DEFAULT_RAS): Changed to forRemoval = false. Also annotated GenericResourceAwareStrategyOld and DefaultResourceAwareStrategyOld with @Deprecated(since = "2.3.0", forRemoval = false) directing users to the current non-"Old" strategies.
3. Flux.java & NodeSorter* private members: Removed (since = "...", forRemoval = true) on private fields and private methods so they remain standard @Deprecated without affecting public API contracts.
4. Rebased onto latest master, resolved merge conflicts in StormMetricRegistry and StormReporter, and verified test compilation with JDK 23 (0 Checkstyle violations).

[rzo1]

Thanks @Mohit20057 for addressing all the points. LGTM.