Repository navigation
Conversation
Release cached filesystems and explicitly owned clients before cluster shutdown. Use tracked clients for tenant tests and the configured EC filesystem for the SequenceFile reader.
rich7420
marked this pull request as ready for review
October 24, 2026 14:12
adoroszlai
marked this pull request as draft
October 27, 2026 07:14
rich7420
marked this pull request as ready for review
October 27, 2026 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds per-command OM client latency metrics to help diagnose slow S3 Gateway requests. Each measured
OmTransport.submitRequestcontributes one latency sample in nanoseconds, including failures, network time, and internal retries.Reuses
PerformanceMetricswith configurable percentiles and a process-wide source shared byRpcClientinstances. The last client releases the source. Also closes leaked test clients before cluster shutdown. This PR covers the OM portion of HDDS-17169.What is the link to the Apache JIRA
HDDS-17169
How was this patch tested?
Revalidated on JDK 21 after merging master at
885f83dd16into27fe1e62d0:TestOmClientMetrics(12),TestOzoneManagerProtocolClientSideTranslatorPB(21), andTestRpcClient(182): all passed, with no skipped tests.TestS3ClientMetrics(3) and the relocatedTestOzoneFileSystemPrefixParser(1). S3 coverage includes PUT/GET/HEAD/LIST, multipart upload, error responses, and/prom//jmxoutput.checkstyle.shpassed.rat.shpassed on a clean export of the committed source tree.27fe1e62d0passed after one rerun of the ozone job. The first attempt failed during scanner teardown withRDBMetricsstill registered; this did not recur on rerun.