Repository navigation
HDDS-17405. Intermittent failure in testFollowerReadOmProxyProviderFailoverOnConnectionFailure - #11728
Merged
Conversation
…follower read test Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change removes the election-timing race without changing the client proxy or weakening failover assertions.
No open issues 🎉
What changed in this PR
This PR stabilizes the OM follower-read failover test by separating leader-election readiness from client connection failover.
Changes:
- Waits for an OM leader after stopping the current proxy OM, before issuing the read.
- Preserves failover coverage by leaving the client pointed at the stopped OM.
| File | Description |
|---|---|
| hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAFollowerReadWithStoppedNodes.java | Adds the existing leader-readiness wait before the failover read. |
Review effort: Balanced
chihsuan
changed the title
smengcl
marked this pull request as ready for review
October 24, 2026 05:50
Member
|
Thanks @chihsuan @smengcl @F64116045 @Russole |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The test stops one OM and sends a read right away. If the stopped OM was the leader, the other two OMs need a moment to pick a new one. Sometimes the client gives up before that happens, and the test fails with "Leader is unknown".
This patch waits for the new leader before sending the read, same as HDDS-16843 did for the sibling test. The client still starts on the stopped OM, so the test still checks the failover.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17405
How was this patch tested?
Generated-by: Claude Code (Opus 5.5)