Repository navigation
fix: preserve braces in Javadoc code tags - #1218
Open
efegokdemir wants to merge 3 commits into
Open
efegokdemir wants to merge 3 commits into
efegokdemir wants to merge 3 commits into
Conversation
Track balanced braces and escaped delimiters when decoding legacy inline tags. Add a regression covering nested property expressions and adjacent Javadoc tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve closing braces inside
{@code ...}content when legacy Javadoc tags are converted to XHTML. This prevents expressions such as${project.basedir}from prematurely terminating the inline tag.Changes
Testing
mvn -pl maven-plugin-tools-generators -am -Dspotless.apply.skip=true -Dspotless.check.skip=true -Dcheckstyle.skip=true -Drat.skip=true test— passed (61 API tests; 18 generator tests, 1 skipped)git diff --check— passedspotless:checkwas attempted but is blocked by the local JDK/Palantir formatter incompatibility (NoSuchFieldErrorinJCTree$JCCompilationUnit).Fixes #823