Repository navigation
Conversation
Use NetworkInterfaceId instead of InstanceId when an interface is supplied, enabling association on instances with multiple interfaces. Preserve existing instance targeting and forward the option through the deprecated alias. Fixes apache#1799
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1799. EC2 instances with multiple network interfaces cannot use the current Elastic IP association method: it always sends
InstanceId, while AWS requiresNetworkInterfaceIdfor that case.Add an optional
network_interfaceparameter accepting the existingEC2NetworkInterfacetype. When supplied, send its ID instead ofInstanceId; existing calls retain their request parameters. Forward the option through the deprecated alias and document its use with VPC addresses.AWS contract: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_AssociateAddress.html
Validation
InstanceId, allocation ID use, legacy instance targeting, and alias forwarding.typing.Listimport inec2.py(also verified against trunk).Status
Ready for review.
Checklist
AI assistance: This implementation, regression tests, and description were prepared with OpenAI Codex.