Repository navigation
KNOX-3535: Fix DefaultTopologyServiceTest - #1474
Merged
Merged
Conversation
The DefaultTopologyServiceTest failed to init the DefaultToplogyService because other unit tests were leaving the static GatewayServer.services field populated. This fix adds a setup and teardown method to unset GatewayServer.services. Other unit tests that don't unset this field were modified to unset this field.
Contributor
Author
lmccay
approved these changes
Oct 28, 2026
lmccay
left a comment
lmccay
left a comment
Contributor
There was a problem hiding this comment.
+1 pending precommit tests
Test Results 4 files 4 suites 1m 31s ⏱️ Results for commit c008780. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3535 - Fix unit test
What changes were proposed in this pull request?
The DefaultTopologyServiceTest failed to init the DefaultToplogyService because other unit tests were leaving the static GatewayServer.services field populated. This fix adds a setup and teardown method to unset GatewayServer.services. Other unit tests that don't unset this field were modified to unset this field.
How was this patch tested?
unit tests were run in the project.
Integration Tests
No integration tests were added because there were no code changes. Only test changes are included in this commit
UI changes
No UI changes