Repository navigation
Conversation
…e param comes after originalUrl
hanicz
requested review from
bonampak,
lmccay,
moresandeep,
pzampino and
smolnar82
October 27, 2026 13:03
Test Results 4 files 4 suites 1m 32s ⏱️ Results for commit 6e2c6b2. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e param comes after originalUrl
KNOX-3532 - KnoxSSO login page redirects to a broken URL when the theme param comes after originalUrl
What changes were proposed in this pull request?
The login page reads
originalUrlby taking everything after originalUrl= (KNOX-820). So a theme param placed after it, as inlogin.html?originalUrl=.../home/&theme=modern, became part of the redirect target. After login the user landed on.../home/&theme=modern, which returns a404.Change: a new
getOriginalUrl()inknoxauth.jsremoves one trailing&theme=<valid-name>fromoriginalUrlbefore it's used for the websso request and the redirect.How was this patch tested?