Repository navigation
JSPWIKI-1226 Add a guid to the items and a link to itself to the RSS 2.0 feed - #652
Draft
arturobernalg wants to merge 1 commit into
Draft
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first change of JSPWIKI-1226 made the links of the feeds absolute. A feed validator still reports two things about the RSS 2.0 feed: the items have no guid, and the channel has no atom:link with rel="self".
This pull request adds both:
Tested with RSSGeneratorTest, which has a new test for the three, and on a running wiki: the output of rss.jsp for type rss20 and for atom has the new elements with absolute addresses. I could not run the W3C validator, because its service answered 502 when I posted the feed.
The empty channel description, the empty language and the managingEditor with only () that the feed shows when those properties are not set are not changed here.
ChangeLog.md and Release.java are updated.