Skip to content

JSPWIKI-1226 Add a guid to the items and a link to itself to the RSS 2.0 feed - #652

Draft
arturobernalg wants to merge 1 commit into
apache:masterfrom
arturobernalg:bug/JSPWIKI-1226-guid-self
Draft

arturobernalg wants to merge 1 commit into
apache:masterfrom
arturobernalg:bug/JSPWIKI-1226-guid-self

Conversation

@arturobernalg

Copy link
Copy Markdown
Member

The first change of JSPWIKI-1226 made the links of the feeds absolute. A feed validator still reports two things about the RSS 2.0 feed: the items have no guid, and the channel has no atom:link with rel="self".

This pull request adds both:

  • each item gets a guid, with isPermaLink set to true, that is the address of the entry, which includes its version
  • the channel gets an atom:link with rel="self" that points to the feed, and the namespace is declared in the root element
  • the link to itself of the Atom feed was a relative address; it is built now by the same method and is absolute

Tested with RSSGeneratorTest, which has a new test for the three, and on a running wiki: the output of rss.jsp for type rss20 and for atom has the new elements with absolute addresses. I could not run the W3C validator, because its service answered 502 when I posted the feed.

The empty channel description, the empty language and the managingEditor with only () that the feed shows when those properties are not set are not changed here.

ChangeLog.md and Release.java are updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant