Repository navigation
JSPWIKI-572 Add tests for the IndexPlugin - #651
Draft
arturobernalg wants to merge 1 commit into
Draft
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IndexPlugin has no tests. JSPWIKI-572 reports that the plugin does not list all the pages when their names differ only in the case of a letter, and that it shows empty entries.
I could not reproduce either on the current master, nor on master-2.x. I created the 17 variants of TEST in a running wiki and the plugin listed all of them, without empty entries. This pull request adds tests so that it does not regress:
The tests pass on master and, adapted to the request helper of that branch, on master-2.x.
ChangeLog.md and Release.java are updated.