Repository navigation
JSPWIKI-1210 Advanced ACL rules, now supports AND/OR and NOT operator… - #484
spyhunter99 wants to merge 1 commit into
Conversation
…s, as well as parenthesis
|
Well, i'll offer up a comment or two.
|
|
I tested this pull request merged into master 3a41a6d (head 7792b69). The ACL tests pass (48 tests), but none of them mixes simple and advanced rules in one page. On a running wiki (war in Tomcat 10.1 in Docker, with an anonymous browser, and master as the control) I found three problems.
|
|
yup it needs work. we can bump to the next next version |
|
or if you want to take it over, be my guest. i'm tied up with other activities unfortunately |
|
Hi Alex, I took this over, as you offered. The work is now in #655: your commit rebased on master, plus further commits that fix the three problems from my review (anonymous users could view a page with only an advanced rule for edit, a simple rule followed by an advanced one was lost, and an advanced rule followed by a simple one failed on save). Thank you for the original work. If you can, please have a look at #655, and I will close this one once it is merged. |
…s, as well as parenthesis