Repository navigation
Fix SystemInfo tests after write memory accounting refactor - #18966
Closed
hongzhi-gao wants to merge 1 commit into
Closed
hongzhi-gao wants to merge 1 commit into
hongzhi-gao wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the 12 compilation errors caused by #18918 tests still calling APIs removed by #18848. Use a DataRegion-owned WriteMemoryBlock and close it in teardown; preserve all existing assertions. Only SystemInfoTest changes. Validation: 16 focused UTs passed; full-reactor English and Chinese test compilation, Spotless and diff checks passed. LOAD ITs were not run.