Repository navigation
Conversation
…18941) Backport the five applicable tree-model lifecycle and protocol assertions, adapting the test paths to the 1.3 layout. Omit the table-model changes, which do not apply to this branch. Restore the consistency helper polling loop using the existing master behavior. The 1.3 helper previously configured failFast without a terminal condition and never queried the receiver. (cherry picked from commit c535723)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partial backport of c535723 (#18941) to
dev/1.3.After stopping a pipe and inserting more sender data, an eventual assertion can succeed on the first read of the receiver's existing contents and miss later unwanted transfers. Port the five applicable tree-model lifecycle/protocol assertions to
assertDataAlwaysOnEnv, and replace the two fixed five-second sleeps with continuous checks. Adapt the paths to the 1.3pipe/it/autocreatelayout; the table-model tests in the original commit do not exist in this branch.The 1.3
assertDataAlwaysOnEnvalso needs a small prerequisite fix: it configures Awaitility'sfailFastcallback without a terminal condition, so it never executes a query. Restore the polling behavior already used on master withduring, a bounded timeout, anduntil, checking the result immediately and throughout the observation window.Enabling these checks exposes stale expectations in the manual schema/auth inclusion tests. Correct the user/privilege column headers, include the replicated schema column when asserting an empty data result, and restore the trailing comma on the timestamp header. Wait eventually for asynchronously replicated privileges; keep continuous assertions for excluded users, databases, and data.
Validation
Apache IoTDB 1.3.7-SNAPSHOT, JDK 17, Windows:
f53fda837ae, Spotless, Checkstyle, and reactortest-compilepassed withwith-integration-tests,MultiClusterIT2ManualCreateSchemaenabled.IoTDBPipeInclusionIT.testPureSchemaInclusion,testAuthExclusion,testAuthInclusionWithPattern, andIoTDBPipeMetaHistoricalIT.testAuthInclusion. Run through direct JUnit method requests using the existingIoTDBTestRunnerand built node templates, withHighPerformanceModeon both sides (Ratis/Ratis/IoT, schema/data replication 3/2). The inclusion tests used 1C3D on each side; the historical test used a 1C3D sender and its required 3C3D receiver. JVM heaps were reduced and two processors exposed to fit the local host.eba6ac4b1db, clean reactor compilation and node template packaging completed. Seven lifecycle/protocol methods passed through the same direct JUnit runner with 1C1D on each side:testLifeCycleLogMode,testLifeCycleFileMode,testLifeCycleHybridMode,testReceiverAlreadyHaveTimeSeries,test1C1DWithRatisRatisIot,test1C1DWithSimpleSimpleIot, andtest1C1DWithRatisRatisSimple.origin/dev/1.3helper.The initial full Maven verification reached integration-test startup but encountered JVM native-memory allocation failures on this Windows host. The lifecycle tests' default 1C3D topology and protocol tests' 3C3D variants remain unverified locally. Full CI is still required.