Repository navigation
Use default credentials in seed fallback IT and centralize IT guidelines - #18944
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SessionSeedNodeFallbackITconstructs its discovery suppliers with hardcodedroot/rootcredentials, while its business session uses the client defaults. In downstream editions with a different default password, discovery can fail authentication and retain the initial seed snapshot until the endpoint assertion times out.Use
SessionConfig.DEFAULT_USERandSessionConfig.DEFAULT_PASSWORDfor both suppliers. Centralize IT authoring and verification guidance inintegration-test/AGENTS.md, covering portable credentials, asynchronous waits, recovery, cleanup, test profiles, and Edge/IDE workflows. Replace duplicated IT instructions in the rootCLAUDE.mdwith an explicit instruction to read the module guidance.Validation
mvn spotless:apply -pl integration-test -P with-integration-testspassed.2fd1c25b05):mvn clean verify -DskipUTs \ '-Dit.test=SessionSeedNodeFallbackIT#testBusinessAndBackgroundRecoveryThroughOmittedSeed' \ -DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=false \ -pl integration-test -am -PClusterIT -P with-integration-testsThe selected IT method ran against an Apache IoTDB 1C3D cluster: 1 test, 0 failures, 0 errors, 0 skipped. Downstream editions were not executed.
This PR has:
Key changed/added classes
SessionSeedNodeFallbackIT