Skip to content

Use default credentials in seed fallback IT and centralize IT guidelines - #18944

Merged
JackieTien97 merged 2 commits into
masterfrom
codex/fix-it-default-credentials
Oct 20, 2026
Merged

JackieTien97 merged 2 commits into
masterfrom
codex/fix-it-default-credentials

Conversation

@JackieTien97

@JackieTien97 JackieTien97 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Description

SessionSeedNodeFallbackIT constructs its discovery suppliers with hardcoded root/root credentials, while its business session uses the client defaults. In downstream editions with a different default password, discovery can fail authentication and retain the initial seed snapshot until the endpoint assertion times out.

Use SessionConfig.DEFAULT_USER and SessionConfig.DEFAULT_PASSWORD for both suppliers. Centralize IT authoring and verification guidance in integration-test/AGENTS.md, covering portable credentials, asynchronous waits, recovery, cleanup, test profiles, and Edge/IDE workflows. Replace duplicated IT instructions in the root CLAUDE.md with an explicit instruction to read the module guidance.

Validation

  • mvn spotless:apply -pl integration-test -P with-integration-tests passed.
  • Documentation links and Maven profile names checked; the Java test is unchanged by the documentation edits.
  • Clean reactor verification passed for the Java change (2fd1c25b05):
mvn clean verify -DskipUTs \
  '-Dit.test=SessionSeedNodeFallbackIT#testBusinessAndBackgroundRecoveryThroughOmittedSeed' \
  -DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=false \
  -pl integration-test -am -PClusterIT -P with-integration-tests

The selected IT method ran against an Apache IoTDB 1C3D cluster: 1 test, 0 failures, 0 errors, 0 skipped. Downstream editions were not executed.

This PR has:

  • been self-reviewed.
  • added integration-test authoring guidelines.
  • been tested in an IoTDB test cluster.
Key changed/added classes
  • SessionSeedNodeFallbackIT

@JackieTien97 JackieTien97 changed the title Use default credentials in seed fallback IT and add IT guidelines Use default credentials in seed fallback IT and centralize IT guidelines Oct 20, 2026
@JackieTien97
JackieTien97 merged commit ddb1741 into master Oct 20, 2026
35 of 39 checks passed
@JackieTien97
JackieTien97 deleted the codex/fix-it-default-credentials branch October 20, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant