Repository navigation
Add missing @Test to testCurrentStateMetrics (#3198) - #3199
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #3198
Description
testCurrentStateMetricsnever had@Test, so TestNG never ran it. This adds the annotation and unregisters the monitor in afinallyblock, so a failure cannot leak its MBean into the next test in the class.Tests
TestRoutingTableProviderMonitor.testCurrentStateMetrics(now runs; fails ifrecordStatePropagationLatencystops updating the gauge).mvn -pl helix-core test -Dtest=TestRoutingTableProviderMonitor: Tests run: 3, Failures: 0