Repository navigation
[rpc] Measure synchronous request processing time - #4845
Open
platinumhamburg wants to merge 1 commit into
Open
platinumhamburg wants to merge 1 commit into
platinumhamburg wants to merge 1 commit into
Conversation
Record per-request worker occupancy separately from asynchronous response completion. Export its duration distribution and cumulative sum by existing request type, including failed requests.
platinumhamburg
marked this pull request as ready for review
October 23, 2026 22:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #4844.
requestProcessTimeMsincludes time spent waiting for an asynchronous response future, including delayed writes. It does not show how long an RPC occupies a request worker. This change measures that synchronous interval separately.Brief change log
requestSyncProcessTimeUsfrom request dequeue through synchronous processing and request-buffer release, including failed requests.requestSyncProcessTimeUsSumfor interval worker-time accounting by the existing request type groups.Tests
./mvnw -pl fluss-rpc -am -Dtest=RequestProcessorMetricsTest,RequestsMetricsTest,NettyServerHandlerTest -Dsurefire.failIfNoSpecifiedTests=false test -qpassed.RequestProcessorMetricsTestafter its final test adjustment; passed.git diff --checkpassed.API and Format
Adds two server metrics. No RPC API or storage format changes.
Documentation
Updated the request metric reference with the synchronous timing boundary and its distinction from asynchronous request completion.