Skip to content

FINERACT-2351: Fixed TaxGroup and TaxComponent API serialization issues - #6722

Open
Abda11ah255 wants to merge 2 commits into
apache:developfrom
Abda11ah255:FINERACT-2351
Open

Abda11ah255 wants to merge 2 commits into
apache:developfrom
Abda11ah255:FINERACT-2351

Conversation

@Abda11ah255

@Abda11ah255 Abda11ah255 commented Oct 22, 2026 •

Copy link
Copy Markdown

Description

Fixed missing @Getter annotation in TaxGroup.java and corrected spelling mismatch for startDate getter in TaxComponent.java which were causing API serialization issues (returning empty data). This resolves FINERACT-2351.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
  • I followed the AI Policy.

@Abda11ah255
Abda11ah255 force-pushed the FINERACT-2351 branch 2 times, most recently from a5be71b to acd5229 Compare October 23, 2026 18:43
@Abda11ah255

Copy link
Copy Markdown
Author

@adamsaghy beside the verify commit signature
are the other 2 failed checks happen due to failure to the eclipse foundation servers ?
Just to make sure I have something wrong before I do a new PR and it gets alot of time untill it gets verified
and lastly could you please assign me to a new issue.
sincerely

@Abda11ah255
Abda11ah255 force-pushed the FINERACT-2351 branch 3 times, most recently from 7f9c140 to cab0151 Compare October 27, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant