Skip to content

[i18n] Default manual Korean runs to generate and name the LLM in the translation notice - #4414

Merged
morningman merged 3 commits into
apache:masterfrom
morningman:feat/korean-manual-generate-default
Oct 21, 2026
Merged

morningman merged 3 commits into
apache:masterfrom
morningman:feat/korean-manual-generate-default

Conversation

@morningman

@morningman morningman commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Why

Two small follow-ups to the translation work:

  • Manual runs of the Korean translation workflow defaulted to dry-run, while the Japanese workflow defaults to generate. The Korean default dates from when Korean generation was manual-only. Korean runs have been scheduled since [ci](i18n) Schedule Korean translation runs twice daily #4409, so both workflows now use the same default: a manual run started without changing the mode generates, like a scheduled run.
  • The notice on translated docs pages said the page was machine translated. These pages are translated by a large language model, and the notice now says so.

What changed

1. Manual Korean runs generate by default

  • korean-translation.yml: the manual mode input defaults to generate. dry-run and validate can still be selected. Scheduled runs are unchanged.
  • translation-workflows.test.cjs: the contract test now requires both workflows to default to generate and checks that the default passes the generation gate. A run with dry-run selected still never reaches the generator.
  • translations/README.md: updated the two sentences that described the Korean dry-run default.

2. The translated-page notice names the large language model

docs.translation.machine is the notice on Japanese and Korean docs pages whose translation is current and has not been reviewed by a person.

Locale Before After
English default This page is machine translated. This page was translated by a large language model (LLM).
Japanese このページは機械翻訳されています。 このページは大規模言語モデル(LLM)によって翻訳されています。
Korean 이 페이지는 기계 번역되었습니다. 이 페이지는 대규모 언어 모델(LLM)로 번역되었습니다.

A locale without its own entry would show the English default; English pages have no notice. The other notices (reviewed by a person, stale, not translated, unverified) are unchanged.

Effect

  • A Korean run started from the Actions page without changing the mode now generates a batch when pages are pending. It calls the model and opens a labeled PR for review, as a Japanese manual run does. Nothing is merged automatically. For a read-only check, select dry-run (or pass -f mode=dry-run).
  • After the next deployment, every machine-translated Japanese and Korean docs page shows the new notice.

The lock and triggers are unchanged, and a run already in progress keeps the workflow definition it started with, so this can be merged at any time.

Verification

  • All 21 translation test suites in Build Check pass on Node 20.20.2 (193 tests), and so do the publish suite and state.test.cjs, which reads both dictionaries.
  • Restoring the dry-run default makes two contract tests fail.
  • check-configuration --all passes. The Japanese and Korean translation gates (check-translations --base 82ccae8) report no errors or warnings.
  • The longer default message is wrapped to stay within the 120-column Prettier width.
  • actionlint 1.7.12 reports nothing new. The two remaining findings, the queue concurrency key and actions/setup-python@v4, also exist on master.

🤖 Generated with Claude Code

Manual dispatch of the Korean workflow defaulted to dry-run, while the
Japanese workflow defaults to generate. Both now default to generate, the
mode a scheduled run uses; dry-run and validate can still be selected.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…tice

The notice on machine-translated docs pages now says the page was
translated by a large language model (LLM), in the English default and in
the Japanese and Korean dictionaries.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@morningman morningman changed the title [ci](i18n) Default manual Korean translation runs to generate [i18n] Default manual Korean runs to generate and name the LLM in the translation notice Oct 20, 2026
@morningman
morningman merged commit d0a4611 into apache:master Oct 21, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
Production — d4437312 Deployed Oct 21, 2026 by morningman via Build Check #8910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant