Repository navigation
[i18n] Default manual Korean runs to generate and name the LLM in the translation notice - #4414
Merged
morningman merged 3 commits intoOct 21, 2026
Conversation
Manual dispatch of the Korean workflow defaulted to dry-run, while the Japanese workflow defaults to generate. Both now default to generate, the mode a scheduled run uses; dry-run and validate can still be selected. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…tice The notice on machine-translated docs pages now says the page was translated by a large language model (LLM), in the English default and in the Japanese and Korean dictionaries. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two small follow-ups to the translation work:
dry-run, while the Japanese workflow defaults togenerate. The Korean default dates from when Korean generation was manual-only. Korean runs have been scheduled since [ci](i18n) Schedule Korean translation runs twice daily #4409, so both workflows now use the same default: a manual run started without changing the mode generates, like a scheduled run.What changed
1. Manual Korean runs generate by default
korean-translation.yml: the manualmodeinput defaults togenerate.dry-runandvalidatecan still be selected. Scheduled runs are unchanged.translation-workflows.test.cjs: the contract test now requires both workflows to default togenerateand checks that the default passes the generation gate. A run withdry-runselected still never reaches the generator.translations/README.md: updated the two sentences that described the Koreandry-rundefault.2. The translated-page notice names the large language model
docs.translation.machineis the notice on Japanese and Korean docs pages whose translation is current and has not been reviewed by a person.A locale without its own entry would show the English default; English pages have no notice. The other notices (reviewed by a person, stale, not translated, unverified) are unchanged.
Effect
dry-run(or pass-f mode=dry-run).The lock and triggers are unchanged, and a run already in progress keeps the workflow definition it started with, so this can be merged at any time.
Verification
state.test.cjs, which reads both dictionaries.dry-rundefault makes two contract tests fail.check-configuration --allpasses. The Japanese and Korean translation gates (check-translations --base 82ccae8) report no errors or warnings.queueconcurrency key andactions/setup-python@v4, also exist on master.🤖 Generated with Claude Code