Repository navigation
[fix] Use MS state for disaggregated BE decommission - #523
Merged
Merged
Conversation
This was referenced Oct 20, 2026
Closed
morningman
pushed a commit
that referenced
this pull request
Oct 20, 2026
…rsistence (#523, #524) (#526) * [feature](operator) Persist mutable FE BE and MS configuration (#524) * [feature](operator) Persist mutable FE BE and MS configuration Preserve mutable runtime configuration on existing safe PVCs while keeping user ConfigMaps unchanged. Record compatibility defaults for existing clusters and provide a verified opt-in migration tool. * Retain runtime configuration PVCs during compute group scale-down (cherry picked from commit d4ae3df) * [fix] Use MS state for disaggregated BE decommission (#523) * fix: use MS state for disaggregated BE decommission * Fix MS instance query colon compatibility (cherry picked from commit 7c6de21)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
DDC scale-down interprets
SystemDecommissionedandTabletNumusing a single kernel's semantics. On kernels that publishSystemDecommissionedonly after completion, this can repeatedly submit decommission SQL. DROP errors could also be ignored before reducing pod replicas.Use MS node states as the completion authority and persist a per-target task in a StatefulSet annotation:
Release note
Decommission scale-down now waits for MS completion and FE synchronization. MS administrative HTTP access, SQL access to every registered FE, and permission to inspect FE configuration are required. Unreachable FEs, uncertain submissions, and changes to an active replica target pause the task; recovery guidance is included in the scaling documentation.
Check List (For Author)
Validation:
go test -race ./pkg/common/utils/metaservice ./pkg/common/utils/mysql ./pkg/controller/sub_controller/disaggregated_cluster/computegroups -count=1passed.go vet ./...and operator build passed.make manifests generatepassed without generated-file changes;git diff --checkpassed.go test ./...was attempted. The existing FETest_ClearResourcesblocked waiting for informer synchronization and was interrupted after approximately four minutes; other reported packages passed. Live SelectDB 3.x/4.x cluster validation has not been performed.