Repository navigation
Fix NIO error handling in visible and non-empty file filters (f009) - #894
Merged
garydgregory merged 2 commits intoOct 19, 2026
Merged
garydgregory merged 2 commits into
garydgregory merged 2 commits into
Conversation
Negate status predicates before handling IOException so VISIBLE and NOT_EMPTY reject paths whose status cannot be determined. Reuse PathUtils.isEmptyDirectory() for directory checks while preserving null and classic File behavior. Document the behavior and add regression tests for status, directory-open, directory-close, and missing-path errors.
Unwrap DirectoryIteratorException so the existing IOException handler rejects paths whose empty status cannot be determined. Document the behavior and add regression coverage for both filters, matches(), stream closure, and subclass error-handler behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix NIO error handling in visible and non-empty file filters (f009)
Negate status predicates before handling IOException so VISIBLE and NOT_EMPTY reject paths whose status cannot be determined.
Reuse PathUtils.isEmptyDirectory() for directory checks while preserving null and classic File behavior. Document the behavior and add regression tests for status, directory-open, directory-close, and missing-path errors.
mvn; that'smvnon the command line by itself.