Repository navigation
Add import support for service offering resources - #359
Open
dheeraj12347 wants to merge 1 commit into
Open
dheeraj12347 wants to merge 1 commit into
dheeraj12347 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #358.
Implemented import support for the following Plugin Framework resources:
cloudstack_service_offering_fixedcloudstack_service_offering_constrainedcloudstack_service_offering_unconstrainedEach resource now implements
resource.ResourceWithImportStateand usesresource.ImportStatePassthroughIDto populate theidattribute from the import identifier. The existingRead()implementation can then retrieve the service offering by ID.Added import-state verification steps to the acceptance tests for all three resources.
Testing
go test ./cloudstack— passedgo test ./...— passedgit diff --check— passedTesting limitation: I do not currently have access to a configured CloudStack environment, so I could not run the acceptance tests against a live CloudStack instance. The local Go test suite passes.