Skip to content

Add unit tests - #110

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:add-unit-tests-for-node-and-zone-paths
Oct 26, 2026
Merged

DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:add-unit-tests-for-node-and-zone-paths

Conversation

@vishesh92

Copy link
Copy Markdown
Member

Adds unit tests for code that called CloudStack or the Kubernetes API without any test: node and instance lookups, zone lookups, service annotation patching, and the GetLoadBalancer, UpdateLoadBalancer and EnsureLoadBalancerDeleted entry points. Each test asserts the CloudStack call and its parameters, including the project id. Test-only change; unit coverage goes from 78% to 94%.

Fixes #23

Copilot AI balanced review requested due to automatic review settings October 23, 2026 08:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.72%. Comparing base (b4335bf) to head (35beee4).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #110       +/-   ##
===========================================
+ Coverage   73.83%   92.72%   +18.88%     
===========================================
  Files           5        5               
  Lines        1525     1525               
===========================================
+ Hits         1126     1414      +288     
+ Misses        350       81      -269     
+ Partials       49       30       -19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, unit tests only, ...

@DaanHoogland
DaanHoogland merged commit 363cd03 into apache:main Oct 26, 2026
11 checks passed
@DaanHoogland
DaanHoogland deleted the add-unit-tests-for-node-and-zone-paths branch October 26, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests

5 participants