Repository navigation
[Main] Add Apache HAWQ attribution for gpcontrib/pxf_fdw - #2125
Merged
Merged
Conversation
leborchuk
approved these changes
Oct 14, 2026
TomShawn
approved these changes
Oct 16, 2026
Greenplum Database took part of gpcontrib/pxf_fdw from the PXF external table client in Apache HAWQ in 2017, and six of its files still contain HAWQ code. Neither LICENSE nor NOTICE mentioned HAWQ. List those six files in the Apache License part of the Greenplum section in LICENSE. Add HAWQ's copyright notice to NOTICE, worded the same way as in cloudberry-pxf's NOTICE. The table shows what fraction of each file's code lines (whitespace normalized) also appear in the HAWQ file: pxf_filter.h 64% src/include/access/pxffilters.h libchurl.c 60% src/backend/access/external/libchurl.c pxf_filter.c 50% src/backend/access/external/pxffilters.c libchurl.h 33% src/include/access/libchurl.h pxf_fragment.h 30% src/include/access/pxfutils.h pxf_header.c 26% src/backend/access/external/pxfheaders.c pxf_bridge.c, pxf_bridge.h and pxf_header.h carry the same ASF header but have no lines in common with HAWQ, and LICENSE now says so. pxf_deparse.c and pxf_option.c come from postgres_fdw and file_fdw, and the PostgreSQL section already covers them. Assisted-by: Claude Code
tuhaihe
force-pushed
the
license-hawq-pxf-fdw
branch
from
October 16, 2026 12:29
fe1f36e to
29882a8
Compare
tuhaihe
enabled auto-merge (rebase)
October 16, 2026 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greenplum Database took part of gpcontrib/pxf_fdw from the PXF external table client in Apache HAWQ in 2017, and six of its files still contain HAWQ code. Neither LICENSE nor NOTICE mentioned HAWQ.
List those six files in the Apache License part of the Greenplum section in LICENSE. Add HAWQ's copyright notice to NOTICE, worded the same way as in cloudberry-pxf's NOTICE.
The table shows what fraction of each file's code lines (whitespace normalized) also appear in the HAWQ file:
pxf_bridge.c, pxf_bridge.h and pxf_header.h carry the same ASF header but have no lines in common with HAWQ, and LICENSE now says so. pxf_deparse.c and pxf_option.c come from postgres_fdw and file_fdw, and the PostgreSQL section already covers them.
Assisted-by: Claude Code
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions