Skip to content

[CALCITE-5696] Support trailing comma in SELECT list for Babel parser(like BigQuery) - #5311

Merged
xuzifu666 merged 1 commit into
apache:mainfrom
xuzifu666:calcite-5696
Oct 17, 2026
Merged

xuzifu666 merged 1 commit into
apache:mainfrom
xuzifu666:calcite-5696

Conversation

@xuzifu666

Copy link
Copy Markdown
Member

@mihaibudiu

Copy link
Copy Markdown
Contributor

If we support trailing commas in select, we should support them in create table too.
but maybe that's a separate issue.

@xuzifu666

Copy link
Copy Markdown
Member Author

If we support trailing commas in select, we should support them in create table too. but maybe that's a separate issue.

That makes sense; I’ve already added support for CREATE TABLE in a recent commit. @mihaibudiu

@xiedeyantu

Copy link
Copy Markdown
Member

As I recall, ClickHouse also supports this feature; it looks good now, so I think you can go ahead.

@xuzifu666

Copy link
Copy Markdown
Member Author

@mihaibudiu Are you happy with current changes? PTAL when you have a time, very thanks!

@sonarqubecloud

Copy link
Copy Markdown

@xuzifu666
xuzifu666 merged commit 402d3db into apache:main Oct 17, 2026
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants