Skip to content

Refactor CMake source and target ownership into module directories #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wasphin wants to merge 9 commits into
base: master
Choose a base branch
from
+1,255 −799
Open

Refactor CMake source and target ownership into module directories #3618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1e5445b
Move CMake source definitions into module directories
wasphin Oct 10, 2026
396fae7
Define CMake production targets in their module directories
wasphin Oct 10, 2026
22edf80
Use explicit installation prefixes for CMake examples
wasphin Oct 17, 2026
9e13e32
Align the ubring example CMake minimum with the project
wasphin Oct 17, 2026
6a91cde
Configure the install prefix before generating pkg-config metadata
wasphin Oct 17, 2026
ebdd972
Prefer generated IDL headers when building the mcpack generator
wasphin Oct 18, 2026
1672bda
Remove unused CMake module configuration leftovers
wasphin Oct 18, 2026
7695dea
Document installed-prefix builds for UBRing examples
wasphin Oct 18, 2026
8cdbade
Preserve ordered transitive dependencies for CMake bundles
wasphin Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ jobs:
cmake -S . -B build -DCMAKE_POLICY_VERSION_MINIMUM=3.5 \
"${cmake_options[@]}"
cmake --build build -j ${{env.proc_num}}
cmake --build build --target cmake_link_checks -j ${{env.proc_num}}

- name: Show ccache statistics
if: always()
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/ci-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ jobs:
run: |
echo "CMAKE_PREFIX_PATH=$(brew --prefix protobuf@21)"
mkdir build && cd build && cmake -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -DWITH_UBRING=ON -DCMAKE_PREFIX_PATH=$(brew --prefix protobuf@21) ..
make -j ${{env.proc_num}} && make clean
make -j ${{env.proc_num}}
cmake --build . --target cmake_link_checks -j ${{env.proc_num}}
make clean

- name: Show ccache statistics
if: always()
Expand Down Expand Up @@ -71,7 +73,9 @@ jobs:
- name: compile with cmake
run: |
mkdir build && cd build && cmake -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -DWITH_UBRING=ON -DCMAKE_PREFIX_PATH=$(brew --prefix protobuf@29) ..
make -j ${{env.proc_num}} && make clean
make -j ${{env.proc_num}}
cmake --build . --target cmake_link_checks -j ${{env.proc_num}}
make clean

- name: Show ccache statistics
if: always()
Expand Down
Loading
Loading