Skip to content

[yaml] - fix post commit yaml test - #40633

Merged
shunping merged 3 commits into
apache:masterfrom
derrickaw:20261016_fixPostYaml
Oct 16, 2026
Merged

shunping merged 3 commits into
apache:masterfrom
derrickaw:20261016_fixPostYaml

Conversation

@derrickaw

@derrickaw derrickaw commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes failures seen here
Problem: _fields doesn't exist in row and I forgot that e2e is part of post commit, so we missed this check during the last PR. My bad.

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.93%. Comparing base (76f6e6d) to head (14195b6).
⚠️ Report is 211 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #40633       +/-   ##
=============================================
+ Coverage     56.16%   79.93%   +23.76%     
=============================================
  Files          1124      488      -636     
  Lines        178336    82557    -95779     
  Branches       1489        0     -1489     
=============================================
- Hits         100170    65990    -34180     
+ Misses        75645    16567    -59078     
+ Partials       2521        0     -2521     
Flag Coverage Δ
go ?
java ?
python 79.93% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw

Copy link
Copy Markdown
Collaborator Author

/gemini review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR fixes a failing post-commit YAML end-to-end test (gcs_avro_to_cloud_bigtable.yaml) by replacing row._fields membership checks with hasattr(row, ...) when checking for field presence in MapToFields callables.

🔍 General Feedback

  • Switching from _fields (an implementation detail not present on all row/namedtuple representations) to hasattr is a clean and idiomatic way to check attribute presence on Beam Row objects in Python callables.
  • No issues found; the changes look good.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@derrickaw
derrickaw marked this pull request as ready for review October 16, 2026 17:25
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @chamikaramj for label yaml.
Backup reviewer: Abacn (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@shunping shunping left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw you triggerred the precommit yaml test, could you trigger the postcommit one (.github/workflows/beam_PostCommit_Yaml_Xlang_Direct.yml) as well? Thanks!

@derrickaw
derrickaw requested a review from shunping October 16, 2026 19:07

@shunping shunping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shunping
shunping merged commit a74f328 into apache:master Oct 16, 2026
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants