Repository navigation
[yaml] - fix post commit yaml test - #40633
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40633 +/- ##
=============================================
+ Coverage 56.16% 79.93% +23.76%
=============================================
Files 1124 488 -636
Lines 178336 82557 -95779
Branches 1489 0 -1489
=============================================
- Hits 100170 65990 -34180
+ Misses 75645 16567 -59078
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
📋 Review Summary
This PR fixes a failing post-commit YAML end-to-end test (gcs_avro_to_cloud_bigtable.yaml) by replacing row._fields membership checks with hasattr(row, ...) when checking for field presence in MapToFields callables.
🔍 General Feedback
- Switching from
_fields(an implementation detail not present on all row/namedtuple representations) tohasattris a clean and idiomatic way to check attribute presence on Beam Row objects in Python callables. - No issues found; the changes look good.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Assigning reviewers: R: @chamikaramj for label yaml. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Fixes failures seen here
Problem: _fields doesn't exist in row and I forgot that e2e is part of post commit, so we missed this check during the last PR. My bad.