Skip to content

Run portable ValidatesRunner tests one at a time - #40632

Merged
Abacn merged 2 commits into
apache:masterfrom
aIbrahiim:flink-pvr-one-thread
Oct 19, 2026
Merged

Abacn merged 2 commits into
apache:masterfrom
aIbrahiim:flink-pvr-one-thread

Conversation

@aIbrahiim

@aIbrahiim aIbrahiim commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

fixes: #38934
caused by: #40324
#38934 (comment)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR limits in-JVM test concurrency for Flink Portable ValidatesRunner tasks to 1 thread (beam.validatesRunner.parallelThreads=1), matching the existing configuration in the Spark job server. This resolves OOMs and test hangs caused by spawning up to 8 concurrent in-process job servers and Flink mini-clusters within a single 4GB test worker JVM.

🔍 General Feedback

  • The fix is clean, well-targeted, and directly addresses the resource contention introduced when beam.test.parallelThreads was defaulted to 8 in #40324 while preserving fork-level parallelism (maxParallelForks = 2).

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@Amar3tto
Amar3tto requested a review from Abacn October 16, 2026 12:31

@Abacn Abacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn

Abacn commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

However it seems the test still stuck, probably other issues introduced since then

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@aIbrahiim

Copy link
Copy Markdown
Contributor Author

However it seems the test still stuck, probably other issues introduced since then

yeah the 1.20 job is the old DataSet suite and those 7 tests already hang on master until they hit the 20 min timeout but the other Flink versions passed. i excluded them for DataSet only so that job can actually finish

@Abacn Abacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm for now, however we still need to fix these tests as Flink 1.20 is LTS. Could you please open an Issue as a release block?

@Abacn

Abacn commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

actually it seems still stuck

@aIbrahiim
aIbrahiim force-pushed the flink-pvr-one-thread branch from 0f2c463 to f420fc9 Compare October 18, 2026 20:18
@aIbrahiim

Copy link
Copy Markdown
Contributor Author

actually it seems still stuck

yeah the hang was from the portable stage context sticking around across jobs in the same jvm so I cleaned that up per job and had to keep the env cache delay so teardown still gets a chance and PostCommit Flink Batch is successful now

@codecov

codecov Bot commented Oct 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.05%. Comparing base (76f6e6d) to head (15c3b9f).
⚠️ Report is 221 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40632      +/-   ##
============================================
+ Coverage     56.16%   65.05%   +8.88%     
- Complexity     2288    13993   +11705     
============================================
  Files          1124     1729     +605     
  Lines        178336   108515   -69821     
  Branches       1489    11313    +9824     
============================================
- Hits         100170    70599   -29571     
+ Misses        75645    33704   -41941     
- Partials       2521     4212    +1691     
Flag Coverage Δ
go ?
java 65.05% <ø> (-10.73%) ⬇️
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @tvalentyn added as fallback since no labels match configuration
Backup reviewer: jrmccluskey (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@aIbrahiim

Copy link
Copy Markdown
Contributor Author

@Abacn PTAL

@Abacn Abacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn
Abacn merged commit bd10258 into apache:master Oct 19, 2026
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Java PVR Flink Batch job is flaky

2 participants