Skip to content

Remove a race with another file write that is not essential to test presence of duplicates. #40596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tvalentyn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove a race with another file write that is not essential to test presence of duplicates. #40596

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ea1f08
Remove a race with another file write that is not essential to test p…
tvalentyn Oct 14, 2026
b4aa168
Replace removed functionality.
tvalentyn Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions sdks/python/apache_beam/io/fileio_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,13 +366,6 @@ def test_without_deduplication(self):
file = self._create_temp_file(dir=tempdir)
# Add file twice, since it will be matched for every interval
files += [file, file]
# Add file name that will be created mid-pipeline
files.append(FileSystems.join(tempdir, 'extra'))

def _create_extra_file(element):
writer = FileSystems.create(FileSystems.join(tempdir, 'extra'))
writer.close()
return element.path

with TestPipeline() as p:
match_continiously = (
Expand All @@ -383,8 +376,7 @@ def _create_extra_file(element):
has_deduplication=False,
start_timestamp=start,
stop_timestamp=stop)
| beam.Map(_create_extra_file))

| beam.Map(lambda element: element.path))
assert_that(match_continiously, equal_to(files))

def test_match_updated_files(self):
Expand Down
Loading